Bug 175751 - Forbid setDragImage after dragstart
Summary: Forbid setDragImage after dragstart
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-18 20:42 PDT by Ryosuke Niwa
Modified: 2017-08-18 23:41 PDT (History)
9 users (show)

See Also:

Attachments
Removes the code (4.91 KB, patch)
2017-08-18 21:35 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-08-18 20:42:20 PDT 
Right now, WebKit allows setting the drag image after dragstart had happened.

However, this doesn't work in WebKit2, and it's pretty much broken in WebKit1,
and doesn't match the spec or the behaviors of Chrome and Firefox.

Remove this broken feature.
Comment 1 Ryosuke Niwa 2017-08-18 21:35:50 PDT 
Created attachment 318581 [details]
Removes the code
Comment 2 Wenson Hsieh 2017-08-18 22:55:05 PDT 
Comment on attachment 318581 [details]
Removes the code

r=me. A bit sad this was never tested at all :(
Comment 3 WebKit Commit Bot 2017-08-18 23:40:33 PDT 
Comment on attachment 318581 [details]
Removes the code

Clearing flags on attachment: 318581

Committed r220951: <http://trac.webkit.org/changeset/220951>
Comment 4 WebKit Commit Bot 2017-08-18 23:40:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-08-18 23:41:09 PDT 
<rdar://problem/33977048>