Bug 175745 – Split the one SWServer::Connection into SWClientConnection and SWServer::Connection

• Status: ASSIGNED
• Component: WebCore Misc.

[Brady Eidson]

Split the one SWServer::Connection into SWClientConnection and SWServer::Connection

Each has much different environments they need to live in.

[Brady Eidson]

Created attachment 318560 [details]
EWS

[Brady Eidson]

Created attachment 318562 [details]
EWS

[Brady Eidson]

Created attachment 318572 [details]
EWS

[Brady Eidson]

Created attachment 318575 [details]
EWS

[Brady Eidson]

Created attachment 318582 [details]
Patch

[Andy Estes]

Comment on attachment 318582 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318582&action=review

I find it a little strange that these "Connection" classes are both MessageSenders and MessageReceivers. It seems like we usually split these into separate classes and don't use the word "ConnectIon" in the receivers. Just something to think about.

> Source/WebCore/workers/service/server/SWClientConnection.cpp:36
> +#include <wtf/HashMap.h>
> +#include <wtf/HashSet.h>
> +#include <wtf/ThreadSafeRefCounted.h>

Two out of three of these are included in SWClientConnection.h

> Source/WebCore/workers/service/server/SWServer.cpp:65
> +    connection.rejectJobInClient(jobData.identifier, ExceptionData { UnknownError, ASCIILiteral("serviceWorker job scheduling is not yet implemented") });

NotSupportedError seems more appropriate. Doesn't really matter since it's temporary code.

[Brady Eidson]

Created attachment 318649 [details]
PFL

[Brady Eidson]

Created attachment 318654 [details]
PFL

[WebKit Commit Bot]

Comment on attachment 318654 [details]
PFL

Clearing flags on attachment: 318654

Committed r220977: <http://trac.webkit.org/changeset/220977>