Bug 175745 - Split the one SWServer::Connection into SWClientConnection and SWServer::Connection
Summary: Split the one SWServer::Connection into SWClientConnection and SWServer::Conn...
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-18 16:43 PDT by Brady Eidson
Modified: 2017-08-21 16:46 PDT (History)
3 users (show)

See Also:

Attachments
EWS (59.65 KB, patch)
2017-08-18 16:54 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
EWS (60.32 KB, patch)
2017-08-18 17:10 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
EWS (3.97 MB, patch)
2017-08-18 19:19 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
EWS (60.12 KB, patch)
2017-08-18 20:10 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (66.18 KB, patch)
2017-08-18 22:14 PDT, Brady Eidson 		aestes: review+
Details | Formatted Diff | Diff
PFL (67.24 KB, patch)
2017-08-21 11:34 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
PFL (64.38 KB, patch)
2017-08-21 11:47 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-08-18 16:43:25 PDT 
Split the one SWServer::Connection into SWClientConnection and SWServer::Connection

Each has much different environments they need to live in.
Comment 1 Brady Eidson 2017-08-18 16:54:45 PDT Comment hidden (obsolete)
Comment 2 Brady Eidson 2017-08-18 17:10:04 PDT Comment hidden (obsolete)
Comment 3 Brady Eidson 2017-08-18 19:19:59 PDT Comment hidden (obsolete)
Comment 4 Brady Eidson 2017-08-18 20:10:43 PDT Comment hidden (obsolete)
Comment 5 Brady Eidson 2017-08-18 22:14:12 PDT 
Created attachment 318582 [details]
Patch
Comment 6 Andy Estes 2017-08-21 10:37:17 PDT 
Comment on attachment 318582 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318582&action=review

I find it a little strange that these "Connection" classes are both MessageSenders and MessageReceivers. It seems like we usually split these into separate classes and don't use the word "ConnectIon" in the receivers. Just something to think about.

> Source/WebCore/workers/service/server/SWClientConnection.cpp:36
> +#include <wtf/HashMap.h>
> +#include <wtf/HashSet.h>
> +#include <wtf/ThreadSafeRefCounted.h>

Two out of three of these are included in SWClientConnection.h

> Source/WebCore/workers/service/server/SWServer.cpp:65
> +    connection.rejectJobInClient(jobData.identifier, ExceptionData { UnknownError, ASCIILiteral("serviceWorker job scheduling is not yet implemented") });

NotSupportedError seems more appropriate. Doesn't really matter since it's temporary code.
Comment 7 Brady Eidson 2017-08-21 11:34:08 PDT 
Created attachment 318649 [details]
PFL
Comment 8 Brady Eidson 2017-08-21 11:47:33 PDT 
Created attachment 318654 [details]
PFL
Comment 9 WebKit Commit Bot 2017-08-21 13:02:47 PDT 
Comment on attachment 318654 [details]
PFL

Clearing flags on attachment: 318654

Committed r220977: <http://trac.webkit.org/changeset/220977>