Bug 175735 – Fix leak-checking for iOS Simulators

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

We can't check leaks for iOS Simulators since we close the process before we check for leaks.

[Jonathan Bedard]

Created attachment 318537 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 318537 [details]
Patch

Clearing flags on attachment: 318537

Committed r220942: <http://trac.webkit.org/changeset/220942>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33972756>

[Jonathan Bedard]

Reopening to attach new patch.

[Jonathan Bedard]

Created attachment 318700 [details]
Patch

[Jonathan Bedard]

Created attachment 318709 [details]
Patch

[David Kilzer (:ddkilzer)]

Comment on attachment 318709 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318709&action=review

r=me

> Tools/Scripts/webkitpy/port/server_process.py:377
>          # read any remaining data on the pipes and return it.
>          if not killed:
> -            if self._use_win32_apis:
> +            if self._use_win32_apis and self._proc:
>                  self._wait_for_data_and_update_buffers_using_win32_apis(now)
> -            else:
> +            elif self._proc:
>                  self._wait_for_data_and_update_buffers_using_select(now, stopping=True)

Can you move the check for self._proc here?

        if not killed and self._proc:

[Jonathan Bedard]

(In reply to David Kilzer (:ddkilzer) from comment #8)
> Comment on attachment 318709 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=318709&action=review
> 
> r=me
> 
> > Tools/Scripts/webkitpy/port/server_process.py:377
> >          # read any remaining data on the pipes and return it.
> >          if not killed:
> > -            if self._use_win32_apis:
> > +            if self._use_win32_apis and self._proc:
> >                  self._wait_for_data_and_update_buffers_using_win32_apis(now)
> > -            else:
> > +            elif self._proc:
> >                  self._wait_for_data_and_update_buffers_using_select(now, stopping=True)
> 
> Can you move the check for self._proc here?
> 
>         if not killed and self._proc:

Good point. Making that change.

[Jonathan Bedard]

Created attachment 318757 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 318757 [details]
Patch for landing

Clearing flags on attachment: 318757

Committed r221011: <http://trac.webkit.org/changeset/221011>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.