Add a "level" field to WTFLogChannel and new log functions and macros so logging can be filtered at runtime.
<rdar://problem/33967234>
Created attachment 318529 [details] Proposed patch.
Attachment 318529 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Assertions.h:176: LOG_CHANNEL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Assertions.h:179: LOG_CHANNEL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Assertions.h:452: Extra space after ( in function call [whitespace/parens] [4] Total errors found: 3 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 318529 [details] Proposed patch. Clearing flags on attachment: 318529 Committed r220938: <http://trac.webkit.org/changeset/220938>
All reviewed patches have been landed. Closing bug.
(In reply to WebKit Commit Bot from comment #4) > Comment on attachment 318529 [details] > Proposed patch. > > Clearing flags on attachment: 318529 > > Committed r220938: <http://trac.webkit.org/changeset/220938> API tests added with this change are failing on iOS Simulator: Tests that failed: LoggingTest.LOG LoggingTest.LOG_WITH_LEVEL LoggingTest.RELEASE_LOG LoggingTest.RELEASE_LOG_IF LoggingTest.RELEASE_LOG_WITH_LEVEL LoggingTest.RELEASE_LOG_WITH_LEVEL_IF https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/builds/3719
Actually, they fail on macOS as well: https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK1%20(Tests)/builds/4068
Reverted r220938 for reason: The API tests added with this change are failing. Committed r220947: <http://trac.webkit.org/changeset/220947>
(In reply to Ryan Haddad from comment #8) > Reverted r220938 for reason: > > The API tests added with this change are failing. > > Committed r220947: <http://trac.webkit.org/changeset/220947> How is it that the so-called "early warning" bots *still* don't run API tests?
It looks like using pipe+fcntl+dup2 to capture stderr output doesn't work on all platforms, so maybe I should disable the tests and commit.
WKWebViewDoesNotLogDuringInitialization.mm uses the same technique to check for logging output, but it only fails if somethings is written to the FD so the test doesn't fail if the technique fails.
Created attachment 318604 [details] Patch for landing.
Attachment 318604 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Assertions.h:176: LOG_CHANNEL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Assertions.h:179: LOG_CHANNEL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Assertions.h:452: Extra space after ( in function call [whitespace/parens] [4] Total errors found: 3 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 318604 [details] Patch for landing. Attachment 318604 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4350245 New failing tests: quicklook/multi-sheet-numbers-09.html
Created attachment 318606 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Comment on attachment 318604 [details] Patch for landing. Clearing flags on attachment: 318604 Committed r220964: <http://trac.webkit.org/changeset/220964>