Bug 175713 – [Curl] Improve multi-threaded networking

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Daewoong Jang]

Another part of patch which fixes bug: https://bugs.webkit.org/show_bug.cgi?id=175253

[Daewoong Jang]

Created attachment 318477 [details]
patch part 2

[Alex Christensen]

Comment on attachment 318477 [details]
patch part 2

View in context: https://bugs.webkit.org/attachment.cgi?id=318477&action=review

> Source/WebCore/platform/network/curl/CurlDownload.cpp:62
> -    m_url = url;
> +    m_url = url.isolatedCopy();

I don't think this is necessary.  This is not the point at which we are moving to another thread.

> Source/WebCore/platform/network/curl/CurlJobManager.cpp:86
> +        default:
> +            ASSERT_NOT_REACHED();

This should be removed.

[Daewoong Jang]

Created attachment 318542 [details]
patch part 2

[Daewoong Jang]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 318477 [details]
> patch part 2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=318477&action=review
> 
> > Source/WebCore/platform/network/curl/CurlDownload.cpp:62
> > -    m_url = url;
> > +    m_url = url.isolatedCopy();
> 
> I don't think this is necessary.  This is not the point at which we are
> moving to another thread.
> 
> > Source/WebCore/platform/network/curl/CurlJobManager.cpp:86
> > +        default:
> > +            ASSERT_NOT_REACHED();
> 
> This should be removed.

I have updated my patch. Thanks for review!

[WebKit Commit Bot]

Comment on attachment 318542 [details]
patch part 2

Clearing flags on attachment: 318542

Committed r220939: <http://trac.webkit.org/changeset/220939>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33972311>