Bug 175713 - [Curl] Improve multi-threaded networking
Summary: [Curl] Improve multi-threaded networking
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daewoong Jang
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-17 22:58 PDT by Daewoong Jang
Modified: 2017-08-18 16:04 PDT (History)
7 users (show)

See Also:


Attachments
patch part 2 (96.67 KB, patch)
2017-08-17 23:01 PDT, Daewoong Jang
achristensen: review+
achristensen: commit-queue-
Details | Formatted Diff | Diff
patch part 2 (96.45 KB, patch)
2017-08-18 14:27 PDT, Daewoong Jang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daewoong Jang 2017-08-17 22:58:38 PDT
Another part of patch which fixes bug: https://bugs.webkit.org/show_bug.cgi?id=175253
Comment 1 Daewoong Jang 2017-08-17 23:01:57 PDT
Created attachment 318477 [details]
patch part 2
Comment 2 Alex Christensen 2017-08-18 13:18:14 PDT
Comment on attachment 318477 [details]
patch part 2

View in context: https://bugs.webkit.org/attachment.cgi?id=318477&action=review

> Source/WebCore/platform/network/curl/CurlDownload.cpp:62
> -    m_url = url;
> +    m_url = url.isolatedCopy();

I don't think this is necessary.  This is not the point at which we are moving to another thread.

> Source/WebCore/platform/network/curl/CurlJobManager.cpp:86
> +        default:
> +            ASSERT_NOT_REACHED();

This should be removed.
Comment 3 Daewoong Jang 2017-08-18 14:27:39 PDT
Created attachment 318542 [details]
patch part 2
Comment 4 Daewoong Jang 2017-08-18 14:30:34 PDT
(In reply to Alex Christensen from comment #2)
> Comment on attachment 318477 [details]
> patch part 2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=318477&action=review
> 
> > Source/WebCore/platform/network/curl/CurlDownload.cpp:62
> > -    m_url = url;
> > +    m_url = url.isolatedCopy();
> 
> I don't think this is necessary.  This is not the point at which we are
> moving to another thread.
> 
> > Source/WebCore/platform/network/curl/CurlJobManager.cpp:86
> > +        default:
> > +            ASSERT_NOT_REACHED();
> 
> This should be removed.

I have updated my patch. Thanks for review!
Comment 5 WebKit Commit Bot 2017-08-18 16:02:55 PDT
Comment on attachment 318542 [details]
patch part 2

Clearing flags on attachment: 318542

Committed r220939: <http://trac.webkit.org/changeset/220939>
Comment 6 WebKit Commit Bot 2017-08-18 16:02:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-08-18 16:04:00 PDT
<rdar://problem/33972311>