Bug 175712 - REGRESSION(r220479): ~8% regression on Speedometer 2 Inferno test
Summary: REGRESSION(r220479): ~8% regression on Speedometer 2 Inferno test
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-17 22:45 PDT by Ryosuke Niwa
Modified: 2017-08-18 14:17 PDT (History)
5 users (show)

See Also:


Attachments
Patch to only enable Inferno subtest (431 bytes, patch)
2017-08-17 22:51 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Reduced test case (136.78 KB, application/zip)
2017-08-18 14:17 PDT, Ryosuke Niwa
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-08-17 22:45:40 PDT
We have a regression on Speedometer 2 (beta)'s Inferno test case:
https://perf.webkit.org/v3/#/charts?since=1500698643580&zoom=(1502150451716.6733-1502403902967.6519)&paneList=((18-977-(1502293749323.2402-1502346683886.86)-null-(5-2.5-500))-(18-896-28434716)-(18-946-28436480))&repository=1

I've made a reduced test case that just runs this test case and the results are follows:

r220473:
66.3 ± 0.72
65.1 ± 0.66

r220476
64.6 ± 0.89
66.58 ± 0.64
65.6 ± 0.78

r220479
62.63 ± 0.51
62.4 ± 0.72
62.2 ± 0.77

r220494:
62.8 ± 1.1
62.69 ± 0.57
62.6 ± 0.89
Comment 1 Ryosuke Niwa 2017-08-17 22:51:30 PDT
Created attachment 318475 [details]
Patch to only enable Inferno subtest

Apply this patch and "Disable Local File Restrictions" in Develop menu to run the test.
Comment 2 Chris Dumez 2017-08-18 09:04:29 PDT
I think it is unlikely to be Sam's https://trac.webkit.org/changeset/220477/webkit. If anything, Sam's patch drops an "if" branch in many cases.

Zalan / Dave should probably take a second look at https://trac.webkit.org/changeset/220479/webkit.
Comment 3 Ryosuke Niwa 2017-08-18 14:14:23 PDT
I've manually built & confirmed the regression comes from r220479:

r220478
67.2 ± 0.82
67.7 ± 0.69
67.9 ± 0.68
66.8 ± 0.92

r220479
63.7 ± 1.2
63.3 ± 0.82
65.53 ± 0.64
64.18 ± 0.55
Comment 4 Ryosuke Niwa 2017-08-18 14:17:21 PDT
Created attachment 318539 [details]
Reduced test case