Bug 175709 – bisect-builds doesn't work due to missing requests module

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryosuke Niwa]

$ ./Tools/Scripts/bisect-builds --help
Traceback (most recent call last):
  File "./Tools/Scripts/bisect-builds", line 33, in <module>
    import requests
ImportError: No module named requests
rniwa-tbmbp:webkit2 rniwa$ ./Tools/Scripts/bisect-builds
Traceback (most recent call last):
  File "./Tools/Scripts/bisect-builds", line 33, in <module>
    import requests
ImportError: No module named requests

[Ryosuke Niwa]

We need to auto-install requests package in webkitpy/thirdparty/__init__.py, and import it from there.

[Radar WebKit Bug Importer]

<rdar://problem/33956917>

[Lucas Forschler]

Created attachment 320289 [details]
patch to move requests module to auto installed

After doing this, the script startup time takes 15 seconds... this is not ideal.

[Lucas Forschler]

Created attachment 320301 [details]
v2 patch

[Lucas Forschler]

using the get_latest_pypi_ur function in the third party stuff creates about 40+ calls out to pypi, which is very slow. I've updated the patch to manually specify the url, which is much faster, nearly instant.

[Ryosuke Niwa]

Comment on attachment 320301 [details]
v2 patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320301&action=review

> Tools/Scripts/webkitpy/thirdparty/__init__.py:114
> +                             "requests-2.18.4/requests")

Wrong indentation. Should be indented by 4 spaces to the right of self._install.

[Lucas Forschler]

Committed revision 221801.

[Ryan Haddad]

(In reply to Lucas Forschler from comment #7)
> Committed revision 221801.

This change introduced a webkitpy test failure:

[1295/1654] webkitpy.thirdparty.__init___unittest.ThirdpartyTest.test_imports erred:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/elcapitan-release-tests-wk2/build/Tools/Scripts/webkitpy/thirdparty/__init___unittest.py", line 66, in test_imports
      import webkitpy.thirdparty.autoinstalled.requests
    File "/Volumes/Data/slave/elcapitan-release-tests-wk2/build/Tools/Scripts/webkitpy/thirdparty/autoinstalled/requests/__init__.py", line 43, in <module>
      import urllib3
  ImportError: No module named urllib3

https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20%28Tests%29/builds/4330

[Ryan Haddad]

Reverted r221801 for reason:

This change introduced a webkitpy test failure.

Committed r221825: <http://trac.webkit.org/changeset/221825>

[Lucas Forschler]

Created attachment 320482 [details]
fix patch to include urllib3

[Lucas Forschler]

The requests module imports urllib3. I don't see an easy way to tell it to use the autoinstalled location. So, this still fails.  I'm going to change the bisect-builds tool to use urllib2, which is installed by default. That will make this go away.

[Lucas Forschler]

Created attachment 320490 [details]
use urllib2 instead of the requests module.

[Lucas Forschler]

Created attachment 320492 [details]
use urllib2 instead of the requests module.

[Lucas Forschler]

Committed revision 221890.