Bug 175675 – -Wreturn-type warnings in CryptoKey.cpp and SubtleCrypto.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Michael Catanzaro]

Some new warnings:

[2743/5943] Building CXX object Source...les/WebCore.dir/crypto/CryptoKey.cpp.o
../../Source/WebCore/crypto/CryptoKey.cpp: In member function ‘WebCore::CryptoKey::AlgorithmVariant WebCore::CryptoKey::algorithm() const’:
../../Source/WebCore/crypto/CryptoKey.cpp:70:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
[2780/5943] Building CXX object Source.../WebCore.dir/crypto/SubtleCrypto.cpp.o
../../Source/WebCore/crypto/SubtleCrypto.cpp: In function ‘WebCore::CryptoKeyUsageBitmap WebCore::toCryptoKeyUsageBitmap(WebCore::CryptoKeyUsage)’:
../../Source/WebCore/crypto/SubtleCrypto.cpp:397:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
../../Source/WebCore/crypto/SubtleCrypto.cpp: In function ‘std::optional<WTF::Variant<WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16>, WebCore::JsonWebKey> > WebCore::toKeyData(WebCore::SubtleCrypto::KeyFormat, WebCore::SubtleCrypto::KeyDataVariant&&, WTF::Ref<WebCore::DeferredPromise>&)’:
../../Source/WebCore/crypto/SubtleCrypto.cpp:479:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^

[Michael Catanzaro]

Created attachment 318374 [details]
Patch

[Jiewen Tan]

Comment on attachment 318374 [details]
Patch

Looks good to me. r=me. Nice!

[WebKit Commit Bot]

Comment on attachment 318374 [details]
Patch

Clearing flags on attachment: 318374

Committed r220876: <http://trac.webkit.org/changeset/220876>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33949830>