WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
175674
[GTK] Remove some obsolete expected failures.
https://bugs.webkit.org/show_bug.cgi?id=175674
Summary
[GTK] Remove some obsolete expected failures.
Ms2ger (he/him; ⌚ UTC+1/+2)
Reported
2017-08-17 09:09:27 PDT
.
Attachments
Patch
(8.10 KB, patch)
2017-08-17 09:11 PDT
,
Ms2ger (he/him; ⌚ UTC+1/+2)
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2
(1.39 MB, application/zip)
2017-08-17 11:52 PDT
,
Build Bot
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 1
2017-08-17 09:11:31 PDT
Created
attachment 318370
[details]
Patch
Michael Catanzaro
Comment 2
2017-08-17 09:14:31 PDT
You need to also close the bugs associated with tests that are now passing, if all the tests are now passing. Good to leave a comment mentioning which commit fixed the tests, if known. If not all the tests are now passing, consider leaving a comment to mention which ones started to pass and when.
Michael Catanzaro
Comment 3
2017-08-17 09:21:58 PDT
Comment on
attachment 318370
[details]
Patch Be sure to check the history of the tests as well, to make sure they're not flaky. For example: $ ./wktesthunter svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg That reveals the test has been alternately timing out and passing. So we should not be removing it from expected failures, because it's still expected to fail. We should be adding a pass expectation so that it doesn't show up under unexpected passes anymore.
Build Bot
Comment 4
2017-08-17 11:52:41 PDT
Comment on
attachment 318370
[details]
Patch
Attachment 318370
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
http://webkit-queues.webkit.org/results/4331474
New failing tests: http/tests/security/cross-origin-indexeddb.html
Build Bot
Comment 5
2017-08-17 11:52:43 PDT
Created
attachment 318393
[details]
Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 6
2017-08-18 00:15:09 PDT
(In reply to Michael Catanzaro from
comment #3
)
> Comment on
attachment 318370
[details]
> Patch > > Be sure to check the history of the tests as well, to make sure they're not > flaky. For example: > > $ ./wktesthunter > svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while- > loading.svg > > That reveals the test has been alternately timing out and passing. So we > should not be removing it from expected failures, because it's still > expected to fail. We should be adding a pass expectation so that it doesn't > show up under unexpected passes anymore.
That's exactly what I did: +
webkit.org/b/174240
svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg [ Pass Timeout ]
Xabier Rodríguez Calvar
Comment 7
2017-08-18 01:41:55 PDT
Comment on
attachment 318370
[details]
Patch And as Michael said, please close the bugs if you can.
WebKit Commit Bot
Comment 8
2017-08-18 02:12:41 PDT
Comment on
attachment 318370
[details]
Patch Clearing flags on attachment: 318370 Committed
r220911
: <
http://trac.webkit.org/changeset/220911
>
WebKit Commit Bot
Comment 9
2017-08-18 02:12:43 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug