Bug 175674 – [GTK] Remove some obsolete expected failures.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Ms2ger (he/him; ⌚ UTC+1/+2)]

.

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 318370 [details]
Patch

[Michael Catanzaro]

You need to also close the bugs associated with tests that are now passing, if all the tests are now passing. Good to leave a comment mentioning which commit fixed the tests, if known.

If not all the tests are now passing, consider leaving a comment to mention which ones started to pass and when.

[Michael Catanzaro]

Comment on attachment 318370 [details]
Patch

Be sure to check the history of the tests as well, to make sure they're not flaky. For example:

$ ./wktesthunter svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg

That reveals the test has been alternately timing out and passing. So we should not be removing it from expected failures, because it's still expected to fail. We should be adding a pass expectation so that it doesn't show up under unexpected passes anymore.

[Build Bot]

Comment on attachment 318370 [details]
Patch

Attachment 318370 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4331474

New failing tests:
http/tests/security/cross-origin-indexeddb.html

[Build Bot]

Created attachment 318393 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 318370 [details]
> Patch
> 
> Be sure to check the history of the tests as well, to make sure they're not
> flaky. For example:
> 
> $ ./wktesthunter
> svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-
> loading.svg
> 
> That reveals the test has been alternately timing out and passing. So we
> should not be removing it from expected failures, because it's still
> expected to fail. We should be adding a pass expectation so that it doesn't
> show up under unexpected passes anymore.

That's exactly what I did:

+webkit.org/b/174240 svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg [ Pass Timeout ]

[Xabier Rodríguez Calvar]

Comment on attachment 318370 [details]
Patch

And as Michael said, please close the bugs if you can.

[WebKit Commit Bot]

Comment on attachment 318370 [details]
Patch

Clearing flags on attachment: 318370

Committed r220911: <http://trac.webkit.org/changeset/220911>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.