Bug 175673 – [GStreamer] GstStructure shouldn't be handled through GRefPtr

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

[GStreamer] GstStructure shouldn't be handled through GRefPtr

[Zan Dobersek]

Created attachment 318368 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 318368 [details]
Patch

O_O

[Michael Catanzaro]

This is bad. How did it not crash? How did it even compile if it doesn't support g_object_ref/unref and there's no template specialization for GstStructure?

[Zan Dobersek]

Comment on attachment 318368 [details]
Patch

Clearing flags on attachment: 318368

Committed r220861: <http://trac.webkit.org/changeset/220861>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.

[Xabier Rodríguez Calvar]

(In reply to Michael Catanzaro from comment #3)
> This is bad. How did it not crash? How did it even compile if it doesn't
> support g_object_ref/unref and there's no template specialization for
> GstStructure?

I ask myself the same question.

[Radar WebKit Bug Importer]

<rdar://problem/33942200>

[Zan Dobersek]

(In reply to Xabier Rodríguez Calvar from comment #6)
> (In reply to Michael Catanzaro from comment #3)
> > This is bad. How did it not crash? How did it even compile if it doesn't
> > support g_object_ref/unref and there's no template specialization for
> > GstStructure?
> 
> I ask myself the same question.

gst_object_ref() was never called because all values were adopted into the GRefPtr<> object. gst_object_unref() was never called because the managed pointer was leaked from the GRefPtr<> object.