Bug 175671 - [EME] MediaKeySession has to initiate playback resume on HTMLMediaElement
Summary: [EME] MediaKeySession has to initiate playback resume on HTMLMediaElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-17 07:16 PDT by Zan Dobersek
Modified: 2017-08-18 09:24 PDT (History)
3 users (show)

See Also:


Attachments
Patch (14.64 KB, patch)
2017-08-17 07:26 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-08-17 07:16:08 PDT
[EME] MediaKeySession has to initiate playback resume on HTMLMediaElement
Comment 1 Zan Dobersek 2017-08-17 07:26:55 PDT
Created attachment 318365 [details]
Patch
Comment 2 Zan Dobersek 2017-08-18 00:45:52 PDT
Comment on attachment 318365 [details]
Patch

Clearing flags on attachment: 318365

Committed r220905: <http://trac.webkit.org/changeset/220905>
Comment 3 Zan Dobersek 2017-08-18 00:45:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2017-08-18 00:47:26 PDT
<rdar://problem/33958693>
Comment 5 Darin Adler 2017-08-18 09:24:20 PDT
Comment on attachment 318365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318365&action=review

> Source/WebCore/html/HTMLMediaElement.h:640
> +    void cdmClientAttemptToResumePlaybackIfNecessary() override;

Slightly better to write "final" here rather than override. Not important at all in this patch, just a general style thing. We should start things both "as private as possible" and "as final as possible" and make them less private and less final as needed.