WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
175671
[EME] MediaKeySession has to initiate playback resume on HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=175671
Summary
[EME] MediaKeySession has to initiate playback resume on HTMLMediaElement
Zan Dobersek
Reported
2017-08-17 07:16:08 PDT
[EME] MediaKeySession has to initiate playback resume on HTMLMediaElement
Attachments
Patch
(14.64 KB, patch)
2017-08-17 07:26 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2017-08-17 07:26:55 PDT
Created
attachment 318365
[details]
Patch
Zan Dobersek
Comment 2
2017-08-18 00:45:52 PDT
Comment on
attachment 318365
[details]
Patch Clearing flags on attachment: 318365 Committed
r220905
: <
http://trac.webkit.org/changeset/220905
>
Zan Dobersek
Comment 3
2017-08-18 00:45:56 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4
2017-08-18 00:47:26 PDT
<
rdar://problem/33958693
>
Darin Adler
Comment 5
2017-08-18 09:24:20 PDT
Comment on
attachment 318365
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=318365&action=review
> Source/WebCore/html/HTMLMediaElement.h:640 > + void cdmClientAttemptToResumePlaybackIfNecessary() override;
Slightly better to write "final" here rather than override. Not important at all in this patch, just a general style thing. We should start things both "as private as possible" and "as final as possible" and make them less private and less final as needed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug