NEW175670
webkit-patch land should remove r and cq flags 
https://bugs.webkit.org/show_bug.cgi?id=175670
Summary webkit-patch land should remove r and cq flags
Xabier Rodríguez Calvar
Reported 2017-08-17 07:03:06 PDT
webkit-patch land should remove r and cq flags
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2017-08-17 17:41:12 PDT
Why is this desirable? r+ in particular is a useful part of patch history, and I think that commit queue removing it is a mistake.
Michael Catanzaro
Comment 2 2017-08-17 19:29:02 PDT
(In reply to Alexey Proskuryakov from comment #1) > Why is this desirable? r+ in particular is a useful part of patch history, > and I think that commit queue removing it is a mistake. I would change commit-queue instead. It's nice to see at a glance who reviewed the patch from Bugzilla. The only harm from flags in closed bugs comes from r? and cq? flags, in which case yes they need to be cleared to remove the patches from request queue. But even that is a bit silly: request queue could just learn to ignore them.
Xabier Rodríguez Calvar
Comment 3 2017-08-18 02:45:59 PDT
I don't care anymore about removing the flag after discussing with people about this. But please, we need to end with the inconsistency of commit-queue clearing the flags and webkit-patch not doing it. The PITA is small but PITA anyway.
Note You need to log in before you can comment on or make changes to this bug.