Bug 175668 - [GStreamer] AppendPipeline: support dispatch of decryption-specific GstStructure into the pipeline
Summary: [GStreamer] AppendPipeline: support dispatch of decryption-specific GstStruct...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks: 174858
  Show dependency tree / graph
 
Reported: 2017-08-17 05:03 PDT by Zan Dobersek
Modified: 2017-08-17 09:42 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.36 KB, patch)
2017-08-17 05:10 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (5.42 KB, patch)
2017-08-17 07:41 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-08-17 05:03:01 PDT 
[GStreamer] AppendPipeline: support dispatch of decryption-specific GstStructure intothe pipeline
Comment 1 Zan Dobersek 2017-08-17 05:10:48 PDT 
Created attachment 318353 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2017-08-17 06:11:40 PDT 
Comment on attachment 318353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318353&action=review

> Source/WebCore/ChangeLog:3
> +        [GStreamer] AppendPipeline: support dispatch of decryption-specific GstStructure intothe pipeline

intothe

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:-95
> -private:

Oops?

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:155
> +    GstStructure* m_pendingDecryptionStructure { nullptr };

Let's make this a GRefPtr.
Comment 3 Zan Dobersek 2017-08-17 06:23:19 PDT 
Comment on attachment 318353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318353&action=review

>> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:-95
>> -private:
> 
> Oops?

No, it removes a duplicated label that you can see above.

>> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:155
>> +    GstStructure* m_pendingDecryptionStructure { nullptr };
> 
> Let's make this a GRefPtr.

GstStructure isn't ref-counted.
Comment 4 Xabier Rodríguez Calvar 2017-08-17 06:29:30 PDT 
(In reply to Zan Dobersek from comment #3)
> > Oops?
> 
> No, it removes a duplicated label that you can see above.

Good then.

> >> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:155
> >> +    GstStructure* m_pendingDecryptionStructure { nullptr };
> > 
> > Let's make this a GRefPtr.
> 
> GstStructure isn't ref-counted.

You're right. You need to use GUniquePtr instead.
Comment 5 Zan Dobersek 2017-08-17 07:41:38 PDT 
Created attachment 318367 [details]
Patch
Comment 6 Zan Dobersek 2017-08-17 09:40:59 PDT 
Comment on attachment 318367 [details]
Patch

Clearing flags on attachment: 318367

Committed r220862: <http://trac.webkit.org/changeset/220862>
Comment 7 Zan Dobersek 2017-08-17 09:41:03 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-08-17 09:42:05 PDT 
<rdar://problem/33942309>