Bug 175649 - [PAL] Move spi/mac directory into PAL
Summary: [PAL] Move spi/mac directory into PAL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-16 17:04 PDT by Yoshiaki Jitsukawa
Modified: 2017-08-21 16:28 PDT (History)
7 users (show)

See Also:

Attachments
Patch (125.16 KB, patch)
2017-08-16 17:43 PDT, Yoshiaki Jitsukawa 		no flags Details | Formatted Diff | Diff
Patch (125.16 KB, patch)
2017-08-16 18:17 PDT, Yoshiaki Jitsukawa 		no flags Details | Formatted Diff | Diff
Patch (123.85 KB, patch)
2017-08-17 19:59 PDT, Yoshiaki Jitsukawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yoshiaki Jitsukawa 2017-08-16 17:04:28 PDT 
Related ticket: Bug 175057 - [PAL] Move spi/cf directory into PAL

This is to move WebCore/platform/spi/mac directory into PAL.
Comment 1 Yoshiaki Jitsukawa 2017-08-16 17:43:17 PDT 
Created attachment 318312 [details]
Patch

 - Move WebCore/platform/spi/mac to WebCore/PAL/pal/spi/mac
 - Fix Xcode projects for it
 - Fix include paths
 - Fix relevant coding style errors
 - Make the style checker ignore false positive "whitespace/operators" error for __has_include()
Comment 2 Build Bot 2017-08-16 17:46:35 PDT 
Attachment 318312 [details] did not pass style-queue:


ERROR: Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 84 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yoshiaki Jitsukawa 2017-08-16 18:17:05 PDT 
Created attachment 318313 [details]
Patch

Hmm, the style checker on my env doesn't complain about the [build/include_order] 
error, but I try restoring the blank line.
Comment 4 Build Bot 2017-08-16 18:18:56 PDT 
Attachment 318313 [details] did not pass style-queue:


ERROR: Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm:33:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 84 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Yoshiaki Jitsukawa 2017-08-17 19:59:00 PDT 
Created attachment 318459 [details]
Patch
Comment 6 WebKit Commit Bot 2017-08-21 13:35:43 PDT 
Comment on attachment 318459 [details]
Patch

Clearing flags on attachment: 318459

Committed r220979: <http://trac.webkit.org/changeset/220979>
Comment 7 WebKit Commit Bot 2017-08-21 13:35:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-08-21 13:37:02 PDT 
<rdar://problem/33998139>
Comment 9 Yoshiaki Jitsukawa 2017-08-21 16:28:13 PDT 
Thank you for your reviewing, Myles ;)