Bug 175620 - [WebCrypto] Push WorkQueue dispatches for HKDF, HMAC, PBKDF2 algorithms into shared code
Summary: [WebCrypto] Push WorkQueue dispatches for HKDF, HMAC, PBKDF2 algorithms into ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-15 21:57 PDT by Zan Dobersek
Modified: 2017-08-29 04:31 PDT (History)
3 users (show)

See Also:

Attachments
WIP patch (24.26 KB, patch)
2017-08-15 22:06 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
WIP patch (36.04 KB, patch)
2017-08-16 07:45 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (37.40 KB, patch)
2017-08-18 00:12 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (36.18 KB, patch)
2017-08-21 04:20 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (31.95 KB, patch)
2017-08-25 01:19 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (31.97 KB, patch)
2017-08-29 00:54 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-08-15 21:57:15 PDT 
SSIA.
Comment 1 Zan Dobersek 2017-08-15 22:06:41 PDT 
Created attachment 318229 [details]
WIP patch
Comment 2 Build Bot 2017-08-15 22:08:23 PDT 
Attachment 318229 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zan Dobersek 2017-08-16 07:45:27 PDT 
Created attachment 318259 [details]
WIP patch
Comment 4 Build Bot 2017-08-16 07:47:12 PDT 
Attachment 318259 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Zan Dobersek 2017-08-18 00:12:22 PDT 
Created attachment 318482 [details]
Patch

Ready for review.
Comment 6 Zan Dobersek 2017-08-21 04:20:09 PDT 
Created attachment 318625 [details]
Patch
Comment 7 Zan Dobersek 2017-08-25 01:19:34 PDT 
Created attachment 319070 [details]
Patch
Comment 8 Jiewen Tan 2017-08-28 12:16:59 PDT 
Comment on attachment 319070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319070&action=review

Looks good to me. r=me. Good job.

> Source/WebCore/crypto/mac/CryptoAlgorithmHMACMac.cpp:102
> +    return signature.size() == expectedSignature.size() && !constantTimeMemcmp(expectedSignature.data(), signature.data(), expectedSignature.size());

Forget to copy a comment here.
Comment 9 Zan Dobersek 2017-08-29 00:54:11 PDT 
Created attachment 319248 [details]
Patch for landing
Comment 10 Zan Dobersek 2017-08-29 04:30:51 PDT 
Comment on attachment 319248 [details]
Patch for landing

Clearing flags on attachment: 319248

Committed r221294: <http://trac.webkit.org/changeset/221294>
Comment 11 Zan Dobersek 2017-08-29 04:30:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2017-08-29 04:31:31 PDT 
<rdar://problem/34130599>