Bug 175615 - Update to changeSelectionWithTouchAt:baseIsStart:withFlags:
Summary: Update to changeSelectionWithTouchAt:baseIsStart:withFlags:
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-15 20:26 PDT by Megan Gardner
Modified: 2017-08-17 18:40 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.60 KB, patch)
2017-08-15 20:35 PDT, Megan Gardner 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2017-08-15 20:26:18 PDT 
Update to changeSelectionWithTouchAt:baseIsStart:withFlags:
Comment 1 Megan Gardner 2017-08-15 20:35:46 PDT 
Created attachment 318219 [details]
Patch
Comment 2 Tim Horton 2017-08-16 16:06:44 PDT 
Comment on attachment 318219 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318219&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2551
> +        selectionChangedWithGesture(self, point, gestureType, gestureState, flags | innerFlags, error);

are the flags handed back from selectWithGesture UIWKSelectionFlags? why are we ORing them together? should we pass flags into selectWithGesture and then back out, instead? it's kind of unusual to smush them together like this (but maybe it makes sense?)
Comment 3 Megan Gardner 2017-08-17 18:39:38 PDT 
https://trac.webkit.org/changeset/220895/webkit
Comment 4 Radar WebKit Bug Importer 2017-08-17 18:40:43 PDT 
<rdar://problem/33955113>