Bug 175585 – Support the 'with' keyword in FTL

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Robin Morisset]

What it says in the title. This is an extension of https://bugs.webkit.org/show_bug.cgi?id=175470.

[Robin Morisset]

Created attachment 318192 [details]
Patch

[Saam Barati]

Comment on attachment 318192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318192&action=review

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:5655
> +            Node* scopeObject = get(VirtualRegister(currentInstruction[3].u.operand));

FWIW, I think a less confusing variable name would just be "object" instead of "scopeObject" here and in other places

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1713
> +        case PushWithScope:

I think it's nice to document like before as KnownCellUse instead of CellUse.

[Keith Miller]

Comment on attachment 318192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318192&action=review

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:5656
> -            Node* scopeObject = get(VirtualRegister(currentInstruction[2].u.operand));
> -            Node* currentScope = get(VirtualRegister(currentInstruction[3].u.operand));
> -            set(VirtualRegister(currentInstruction[1].u.operand), addToGraph(PushWithScope, scopeObject, currentScope));
> +            Node* currentScope = get(VirtualRegister(currentInstruction[2].u.operand));
> +            Node* scopeObject = get(VirtualRegister(currentInstruction[3].u.operand));
> +            set(VirtualRegister(currentInstruction[1].u.operand), addToGraph(PushWithScope, currentScope, scopeObject));

If you want to be fancy you can use my new bytecode names feature :)

[Robin Morisset]

Created attachment 318203 [details]
Patch, scopeObject => object

[Robin Morisset]

I will refine the type in DFGFixupPhase.cpp in a separate patch since it also applies to other opcodes (CreateActivation, CreateScopedArguments, NewFunction, NewGeneratorFunction, NewAsyncFunction).

[Build Bot]

Attachment 318203 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jit/JITOperations.h:422:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 318203 [details]
Patch, scopeObject => object

Clearing flags on attachment: 318203

Committed r220778: <http://trac.webkit.org/changeset/220778>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.