175583 – Import a better std::variant

Bug 175583 - Import a better std::variant

Summary: Import a better std::variant

Status:	RESOLVED CONFIGURATION CHANGED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Web Template Framework (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Sam Weinig

URL:
Keywords:

Depends on:
Blocks:

Reported:	2017-08-15 10:33 PDT by Sam Weinig
Modified:	2018-09-03 20:46 PDT (History)
CC List:	1 user (show)

See Also:

Attachments
Patch (356.12 KB, patch) 2017-08-17 20:59 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (355.67 KB, patch) 2017-08-17 21:20 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (355.58 KB, patch) 2017-08-18 07:11 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (357.07 KB, patch) 2017-08-18 07:13 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (357.22 KB, patch) 2017-08-18 09:25 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (357.75 KB, patch) 2017-08-19 12:26 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (361.44 KB, patch) 2017-08-19 21:59 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (363.17 KB, patch) 2017-08-19 22:22 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sam Weinig 2017-08-15 10:33:42 PDT

The variant implementation we currently have, https://bitbucket.org/anthonyw/variant/src, is completely standards compliant and is not being updated all that often. We should probably replace it with https://github.com/mpark/variant, which is based on the clang implementation and is  available as a single header, while we wait for all our compilers / standard libraries to support it directly.

Comment 1 Sam Weinig 2017-08-17 20:59:34 PDT Comment hidden (obsolete)

Created attachment 318464 [details]
Patch

Comment 2 Sam Weinig 2017-08-17 21:20:51 PDT Comment hidden (obsolete)

Created attachment 318467 [details]
Patch

Comment 3 Build Bot 2017-08-17 21:25:40 PDT Comment hidden (obsolete)

Comment on attachment 318467 [details]
Patch

Attachment 318467 [details] did not pass bindings-ews (mac):
Output: http://webkit-queues.webkit.org/results/4334654

New failing tests:
(JS) JSTestCallTracer.cpp

Comment 4 Sam Weinig 2017-08-18 07:11:44 PDT Comment hidden (obsolete)

Created attachment 318493 [details]
Patch

Comment 5 Sam Weinig 2017-08-18 07:13:49 PDT Comment hidden (obsolete)

Created attachment 318494 [details]
Patch

Comment 6 Sam Weinig 2017-08-18 09:25:03 PDT Comment hidden (obsolete)

Created attachment 318509 [details]
Patch

Comment 7 Sam Weinig 2017-08-19 12:26:29 PDT Comment hidden (obsolete)

Created attachment 318587 [details]
Patch

Comment 8 Sam Weinig 2017-08-19 21:59:27 PDT Comment hidden (obsolete)

Created attachment 318596 [details]
Patch

Comment 9 Sam Weinig 2017-08-19 22:22:12 PDT

Created attachment 318597 [details]
Patch