RESOLVED FIXED 175571
MemoryCache::setCapacities assertion failure maxDeadBytes <= totalBytes 
https://bugs.webkit.org/show_bug.cgi?id=175571
Summary MemoryCache::setCapacities assertion failure maxDeadBytes <= totalBytes
Charlie Turner
Reported 2017-08-15 08:45:24 PDT
After the grand move from WebKit2 -> WebKit, I was struggling to find information about these caching policies and what exactly they mean. The problem is that calculateMemoryCacheSizes fails to set cacheTotalCapacity to something sensible if the system has less than 512MB of RAM. This, // This code is here to avoid a PLT regression. We can remove it if we // can prove that the overall system gain would justify the regression. cacheMaxDeadCapacity = std::max(24u, cacheMaxDeadCapacity); Then obviously violates the checks in MemoryCache::setCapacities, because at this point cacheTotalCapacity is zero from the callsite. Patch basically follows the pattern to make sure cacheTotalCapacity is set.
Attachments
Patch (2.17 KB, patch)
2017-08-15 08:47 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Charlie Turner
Comment 1 2017-08-15 08:47:24 PDT
Created attachment 318118 [details] Patch
Charlie Turner
Comment 2 2017-08-15 08:49:43 PDT
Adding Sam, because I have no idea who's best to review this patch, and you were the last one I saw doing things with this area, sorry :)
Charlie Turner
Comment 3 2017-08-21 04:36:11 PDT
Please may someone cq+ this for me? I'm not a commiter.
WebKit Commit Bot
Comment 4 2017-08-21 05:59:03 PDT
Comment on attachment 318118 [details] Patch Clearing flags on attachment: 318118 Committed r220963: <http://trac.webkit.org/changeset/220963>
WebKit Commit Bot
Comment 5 2017-08-21 05:59:05 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-08-21 05:59:38 PDT
<rdar://problem/33990750>
Note You need to log in before you can comment on or make changes to this bug.