Enable named offsets into JSC bytecodes
Created attachment 318104 [details]
Created attachment 318123 [details]
Comment on attachment 318123 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=318123&action=review
r=me with fixes. Please rebase and get the EWS bots green before landing.
> + As a first cut I converted the various instanceof bytecodes to use
> + named offsets.
I think it is useful to include a sample of one such generated bytecode struct here. This will give the reader a much more intuitive sense of what this patch does.
> + bytecodeHFile.write("friend class LLIntOffsetsExtractor;\n")
The "friend class ..." declaration should be indented by 4 spaces i.e. need to add 4 spaces at start of string.
Created attachment 318129 [details]
Created attachment 318135 [details]
Comment on attachment 318135 [details]
Clearing flags on attachment: 318135
Committed r220753: <http://trac.webkit.org/changeset/220753>
All reviewed patches have been landed. Closing bug.