Bug 175561 - Enable named offsets into JSC bytecodes
Summary: Enable named offsets into JSC bytecodes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-14 19:53 PDT by Keith Miller
Modified: 2017-08-15 13:15 PDT (History)
3 users (show)

See Also:

Attachments
Patch (48.96 KB, patch)
2017-08-14 20:10 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (51.78 KB, patch)
2017-08-15 09:08 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (52.97 KB, patch)
2017-08-15 10:11 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (52.98 KB, patch)
2017-08-15 10:39 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-08-14 19:53:40 PDT 
Enable named offsets into JSC bytecodes
Comment 1 Keith Miller 2017-08-14 20:10:04 PDT 
Created attachment 318104 [details]
Patch
Comment 2 Keith Miller 2017-08-15 09:08:54 PDT 
Created attachment 318123 [details]
Patch
Comment 3 Mark Lam 2017-08-15 09:40:22 PDT 
Comment on attachment 318123 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318123&action=review

r=me with fixes.  Please rebase and get the EWS bots green before landing.

> Source/JavaScriptCore/ChangeLog:18
> +        As a first cut I converted the various instanceof bytecodes to use
> +        named offsets.

I think it is useful to include a sample of one such generated bytecode struct here.  This will give the reader a much more intuitive sense of what this patch does.

> Source/JavaScriptCore/generate-bytecode-files:133
> +    bytecodeHFile.write("friend class LLIntOffsetsExtractor;\n")

The "friend class ..." declaration should be indented by 4 spaces i.e. need to add 4 spaces at start of string.
Comment 4 Keith Miller 2017-08-15 10:11:02 PDT 
Created attachment 318129 [details]
Patch
Comment 5 Keith Miller 2017-08-15 10:39:29 PDT 
Created attachment 318135 [details]
Patch
Comment 6 WebKit Commit Bot 2017-08-15 13:13:58 PDT 
Comment on attachment 318135 [details]
Patch

Clearing flags on attachment: 318135

Committed r220753: <http://trac.webkit.org/changeset/220753>
Comment 7 WebKit Commit Bot 2017-08-15 13:13:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-08-15 13:15:15 PDT 
<rdar://problem/33902259>