RESOLVED FIXED 175530
Factor text autosizing into a class 
https://bugs.webkit.org/show_bug.cgi?id=175530
Summary Factor text autosizing into a class
Antti Koivisto
Reported 2017-08-14 04:47:48 PDT
It is currently in Document.
Attachments
patch (10.85 KB, patch)
2017-08-14 05:02 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (10.69 KB, patch)
2017-08-14 05:13 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
patch (10.66 KB, patch)
2017-08-14 05:38 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-08-14 05:02:33 PDT
Created attachment 318032 [details] patch
Antti Koivisto
Comment 2 2017-08-14 05:13:05 PDT
Created attachment 318033 [details] patch
Andreas Kling
Comment 3 2017-08-14 05:14:33 PDT
Comment on attachment 318033 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=318033&action=review r=me > Source/WebCore/rendering/TextAutoSizing.h:128 > + using NodeMap = HashMap<TextAutoSizingKey, std::unique_ptr<TextAutoSizingValue>, TextAutoSizingHash, TextAutoSizingTraits>; > + NodeMap m_textNodes; Seems like this could be accomplished in a single line, no?
Antti Koivisto
Comment 4 2017-08-14 05:38:19 PDT
Created attachment 318035 [details] patch
WebKit Commit Bot
Comment 5 2017-08-14 06:20:51 PDT
Comment on attachment 318035 [details] patch Clearing flags on attachment: 318035 Committed r220685: <http://trac.webkit.org/changeset/220685>
WebKit Commit Bot
Comment 6 2017-08-14 06:20:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-08-14 06:22:26 PDT
<rdar://problem/33874524>
Note You need to log in before you can comment on or make changes to this bug.