Bug 175530 - Factor text autosizing into a class
Summary: Factor text autosizing into a class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-14 04:47 PDT by Antti Koivisto
Modified: 2017-08-14 06:22 PDT (History)
6 users (show)

See Also:

Attachments
patch (10.85 KB, patch)
2017-08-14 05:02 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (10.69 KB, patch)
2017-08-14 05:13 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
patch (10.66 KB, patch)
2017-08-14 05:38 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-08-14 04:47:48 PDT 
It is currently in Document.
Comment 1 Antti Koivisto 2017-08-14 05:02:33 PDT 
Created attachment 318032 [details]
patch
Comment 2 Antti Koivisto 2017-08-14 05:13:05 PDT 
Created attachment 318033 [details]
patch
Comment 3 Andreas Kling 2017-08-14 05:14:33 PDT 
Comment on attachment 318033 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318033&action=review

r=me

> Source/WebCore/rendering/TextAutoSizing.h:128
> +    using NodeMap = HashMap<TextAutoSizingKey, std::unique_ptr<TextAutoSizingValue>, TextAutoSizingHash, TextAutoSizingTraits>;
> +    NodeMap m_textNodes;

Seems like this could be accomplished in a single line, no?
Comment 4 Antti Koivisto 2017-08-14 05:38:19 PDT 
Created attachment 318035 [details]
patch
Comment 5 WebKit Commit Bot 2017-08-14 06:20:51 PDT 
Comment on attachment 318035 [details]
patch

Clearing flags on attachment: 318035

Committed r220685: <http://trac.webkit.org/changeset/220685>
Comment 6 WebKit Commit Bot 2017-08-14 06:20:52 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-08-14 06:22:26 PDT 
<rdar://problem/33874524>