Drop non-const getter for CachedResource::resourceRequest(). It would be unsafe to modify the request of a CachedResource after it has been cached. Exposing such a getter is therefore a footgun.
Created attachment 318011 [details] Patch
Comment on attachment 318011 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318011&action=review > Source/WebCore/loader/LinkLoader.cpp:227 > CachedResourceRequest linkRequest(WTFMove(resourceRequest), CachedResourceLoader::defaultCachedResourceOptions(), CachedResource::defaultPriorityForResourceType(type.value())); Could probably be rewritten to CachedResourceRequest linkRequest(document.completeURL(href),...) or CachedResourceRequest linkRequest(ResourceRequest(document.completeURL(href),...) if we do not like creating implicitly requests from urls.
Created attachment 318015 [details] Patch
Comment on attachment 318015 [details] Patch Clearing flags on attachment: 318015 Committed r220632: <http://trac.webkit.org/changeset/220632>
All reviewed patches have been landed. Closing bug.
<rdar://problem/33868034>