RESOLVED CONFIGURATION CHANGED 175520
Builderror: ‘PointLightSource’ was not declared in this scope 
https://bugs.webkit.org/show_bug.cgi?id=175520
Summary Builderror: ‘PointLightSource’ was not declared in this scope
felix
Reported 2017-08-13 00:55:47 PDT
I get this error while building webkitgtk-2.17.5 or webkit-gtk-2.17.90 on an Armv7 Gentoo system using emerge: /WebCore/CMakeFiles/WebCore.dir/platform/graphics/cpu/arm/filters/FELightingNEON.cpp.o.d -o Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/cpu/arm/filters/FELi ghtingNEON.cpp.o -c /var/tmp/portage/net-libs/webkit-gtk-2.17.90/work/webkitgtk-2.17.90/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.cpp In file included from /var/tmp/portage/net-libs/webkit-gtk-2.17.90/work/webkitgtk-2.17.90/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.cpp:28:0: /var/tmp/portage/net-libs/webkit-gtk-2.17.90/work/webkitgtk-2.17.90/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h: In member function ‘void WebCore: :FELighting::platformApplyNeon(WebCore::FELighting::LightingData&, WebCore::LightSource::PaintingData&)’: /var/tmp/portage/net-libs/webkit-gtk-2.17.90/work/webkitgtk-2.17.90/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:119:9: error: ‘PointLightSource’ w as not declared in this scope PointLightSource* pointLightSource = static_cast<PointLightSource*>(&m_lightSource.get()); ^~~~~~~~~~~~~~~~ /var/tmp/portage/net-libs/webkit-gtk-2.17.90/work/webkitgtk-2.17.90/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:119:27: error: ‘pointLightSource’ was not declared in this scope PointLightSource* pointLightSource = static_cast<PointLightSource*>(&m_lightSource.get()); ^~~~~~~~~~~~~~~~ /var/tmp/portage/net-libs/webkit-gtk-2.17.90/work/webkitgtk-2.17.90/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:119:58: error: ‘PointLightSource’ does not name a type PointLightSource* pointLightSource = static_cast<PointLightSource*>(&m_lightSource.get()); ^~~~~~~~~~~~~~~~ /var/tmp/portage/net-libs/webkit-gtk-2.17.90/work/webkitgtk-2.17.90/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:119:74: error: expected ‘>’ before ‘*’ token PointLightSource* pointLightSource = static_cast<PointLightSource*>(&m_lightSource.get()); ^ /var/tmp/portage/net-libs/webkit-gtk-2.17.90/work/webkitgtk-2.17.90/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:119:74: error: expected ‘(’ before ‘*’ token /var/tmp/portage/net-libs/webkit-gtk-2.17.90/work/webkitgtk-2.17.90/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:119:75: error: expected primary-ex pression before ‘>’ token PointLightSource* pointLightSource = static_cast<PointLightSource*>(&m_lightSource.get()); ^ /var/tmp/portage/net-libs/webkit-gtk-2.17.90/work/webkitgtk-2.17.90/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:119:98: error: expected ‘)’ before ‘;’ token PointLightSource* pointLightSource = static_cast<PointLightSource*>(&m_lightSource.get()); ^ /var/tmp/portage/net-libs/webkit-gtk-2.17.90/work/webkitgtk-2.17.90/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:126:9: error: ‘SpotLightSource’ was not declared in this scope SpotLightSource* spotLightSource = static_cast<SpotLightSource*>(&m_lightSource.get());
Attachments
Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2024-10-15 15:25:26 PDT
The NEON optimizations have been reworked a while back. The source source files mentioned in the build error log no longer exist, so I think we can close this.
Note You need to log in before you can comment on or make changes to this bug.