Bug 175515 - All of the different ArrayBuffer::data's should be CagedPtr<>
Summary: All of the different ArrayBuffer::data's should be CagedPtr<>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on: 176223
Blocks: 174917
  Show dependency tree / graph
 
Reported: 2017-08-12 11:52 PDT by Filip Pizlo
Modified: 2017-09-27 12:46 PDT (History)
14 users (show)

See Also:

Attachments
the patch (15.29 KB, patch)
2017-08-31 12:03 PDT, Filip Pizlo 		msaboff: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-elcapitan (2.79 MB, application/zip)
2017-08-31 13:43 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-08-12 11:52:39 PDT 
...
Comment 1 Filip Pizlo 2017-08-31 12:03:25 PDT 
Created attachment 319494 [details]
the patch
Comment 2 Michael Saboff 2017-08-31 12:58:38 PDT 
Comment on attachment 319494 [details]
the patch

r=me (with wpe build fix)
Comment 3 Build Bot 2017-08-31 13:43:15 PDT 
Comment on attachment 319494 [details]
the patch

Attachment 319494 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4418267

Number of test failures exceeded the failure limit.
Comment 4 Build Bot 2017-08-31 13:43:16 PDT 
Created attachment 319514 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Filip Pizlo 2017-08-31 13:47:28 PDT 
Landed in https://trac.webkit.org/changeset/221439/webkit
Comment 6 Filip Pizlo 2017-08-31 13:51:45 PDT 
(In reply to Build Bot from comment #3)
> Comment on attachment 319494 [details]
> the patch
> 
> Attachment 319494 [details] did not pass mac-debug-ews (mac):
> Output: http://webkit-queues.webkit.org/results/4418267
> 
> Number of test failures exceeded the failure limit.

This looks like an obvious goof. Hopefully fixed in https://trac.webkit.org/changeset/221440/webkit
Comment 7 Radar WebKit Bug Importer 2017-09-27 12:46:42 PDT 
<rdar://problem/34693931>