Bug 175513 - ARM_TRADITIONAL: static assertion failed: ProbeContext_size_matches_ctiMasmProbeTrampoline
Summary: ARM_TRADITIONAL: static assertion failed: ProbeContext_size_matches_ctiMasmPr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-12 10:34 PDT by Mark Lam
Modified: 2017-08-12 23:23 PDT (History)
8 users (show)

See Also:


Attachments
Patch (6.54 KB, patch)
2017-08-12 15:46 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-08-12 10:34:40 PDT
See https://bugs.webkit.org/show_bug.cgi?id=175446#c23.
Comment 1 Mark Lam 2017-08-12 10:35:56 PDT
(In reply to Csaba Osztrogonác_OOO_until_21st_Aug from comment #23 @ https://bugs.webkit.org/show_bug.cgi?id=175446#c23)
> and it broke the ARMv7 (traditional) build too:
> ../../Source/JavaScriptCore/assembler/MacroAssemblerARM.cpp:203:1: error:
> static assertion failed: ProbeContext_size_matches_ctiMasmProbeTrampoline

@Ossy, I cannot fixed / diagnose this issue since I don't have the means to build for traditional ARM.  This static_assert failure here is saying that sizeof(ProbeContext) is not our expected value, 208.  Can you check what sizeof(ProbeContext) is on ARM_TRADITIONAL?
Comment 2 Csaba Osztrogonác 2017-08-12 14:53:43 PDT
(In reply to Mark Lam from comment #1)
> (In reply to Csaba Osztrogonác_OOO_until_21st_Aug from comment #23 @
> https://bugs.webkit.org/show_bug.cgi?id=175446#c23)
> > and it broke the ARMv7 (traditional) build too:
> > ../../Source/JavaScriptCore/assembler/MacroAssemblerARM.cpp:203:1: error:
> > static assertion failed: ProbeContext_size_matches_ctiMasmProbeTrampoline
> 
> @Ossy, I cannot fixed / diagnose this issue since I don't have the means to
> build for traditional ARM.  This static_assert failure here is saying that
> sizeof(ProbeContext) is not our expected value, 208.  Can you check what
> sizeof(ProbeContext) is on ARM_TRADITIONAL?

sizeof(ProbeContext) is 336. Where should I search the root of this issue?
Comment 3 Csaba Osztrogonác 2017-08-12 15:11:22 PDT
(In reply to Csaba Osztrogonác_OOO_until_21st_Aug from comment #2)
> (In reply to Mark Lam from comment #1)
> > (In reply to Csaba Osztrogonác_OOO_until_21st_Aug from comment #23 @
> > https://bugs.webkit.org/show_bug.cgi?id=175446#c23)
> > > and it broke the ARMv7 (traditional) build too:
> > > ../../Source/JavaScriptCore/assembler/MacroAssemblerARM.cpp:203:1: error:
> > > static assertion failed: ProbeContext_size_matches_ctiMasmProbeTrampoline
> > 
> > @Ossy, I cannot fixed / diagnose this issue since I don't have the means to
> > build for traditional ARM.  This static_assert failure here is saying that
> > sizeof(ProbeContext) is not our expected value, 208.  Can you check what
> > sizeof(ProbeContext) is on ARM_TRADITIONAL?
> 
> sizeof(ProbeContext) is 336. Where should I search the root of this issue?

I think I got the root of the problem. There are 32 FP registers, but
only d0-d15 are saved, that's why sizeof(ProbeContext) is 336, not 208.
Comment 4 Csaba Osztrogonác 2017-08-12 15:23:07 PDT
fix is coming
Comment 5 Csaba Osztrogonác 2017-08-12 15:46:55 PDT
Created attachment 318002 [details]
Patch

build works, tests are still running
Comment 6 Mark Lam 2017-08-12 16:47:37 PDT
Comment on attachment 318002 [details]
Patch

r=me
Comment 7 Csaba Osztrogonác 2017-08-12 22:53:40 PDT
Comment on attachment 318002 [details]
Patch

Tests pass, let's land it.
Comment 8 WebKit Commit Bot 2017-08-12 23:22:47 PDT
Comment on attachment 318002 [details]
Patch

Clearing flags on attachment: 318002

Committed r220629: <http://trac.webkit.org/changeset/220629>
Comment 9 WebKit Commit Bot 2017-08-12 23:22:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2017-08-12 23:23:53 PDT
<rdar://problem/33866212>