See https://bugs.webkit.org/show_bug.cgi?id=175446#c23.
(In reply to Csaba Osztrogonác_OOO_until_21st_Aug from comment #23 @ https://bugs.webkit.org/show_bug.cgi?id=175446#c23) > and it broke the ARMv7 (traditional) build too: > ../../Source/JavaScriptCore/assembler/MacroAssemblerARM.cpp:203:1: error: > static assertion failed: ProbeContext_size_matches_ctiMasmProbeTrampoline @Ossy, I cannot fixed / diagnose this issue since I don't have the means to build for traditional ARM. This static_assert failure here is saying that sizeof(ProbeContext) is not our expected value, 208. Can you check what sizeof(ProbeContext) is on ARM_TRADITIONAL?
(In reply to Mark Lam from comment #1) > (In reply to Csaba Osztrogonác_OOO_until_21st_Aug from comment #23 @ > https://bugs.webkit.org/show_bug.cgi?id=175446#c23) > > and it broke the ARMv7 (traditional) build too: > > ../../Source/JavaScriptCore/assembler/MacroAssemblerARM.cpp:203:1: error: > > static assertion failed: ProbeContext_size_matches_ctiMasmProbeTrampoline > > @Ossy, I cannot fixed / diagnose this issue since I don't have the means to > build for traditional ARM. This static_assert failure here is saying that > sizeof(ProbeContext) is not our expected value, 208. Can you check what > sizeof(ProbeContext) is on ARM_TRADITIONAL? sizeof(ProbeContext) is 336. Where should I search the root of this issue?
(In reply to Csaba Osztrogonác_OOO_until_21st_Aug from comment #2) > (In reply to Mark Lam from comment #1) > > (In reply to Csaba Osztrogonác_OOO_until_21st_Aug from comment #23 @ > > https://bugs.webkit.org/show_bug.cgi?id=175446#c23) > > > and it broke the ARMv7 (traditional) build too: > > > ../../Source/JavaScriptCore/assembler/MacroAssemblerARM.cpp:203:1: error: > > > static assertion failed: ProbeContext_size_matches_ctiMasmProbeTrampoline > > > > @Ossy, I cannot fixed / diagnose this issue since I don't have the means to > > build for traditional ARM. This static_assert failure here is saying that > > sizeof(ProbeContext) is not our expected value, 208. Can you check what > > sizeof(ProbeContext) is on ARM_TRADITIONAL? > > sizeof(ProbeContext) is 336. Where should I search the root of this issue? I think I got the root of the problem. There are 32 FP registers, but only d0-d15 are saved, that's why sizeof(ProbeContext) is 336, not 208.
fix is coming
Created attachment 318002 [details] Patch build works, tests are still running
Comment on attachment 318002 [details] Patch r=me
Comment on attachment 318002 [details] Patch Tests pass, let's land it.
Comment on attachment 318002 [details] Patch Clearing flags on attachment: 318002 Committed r220629: <http://trac.webkit.org/changeset/220629>
All reviewed patches have been landed. Closing bug.
<rdar://problem/33866212>