Bug 175513 – ARM_TRADITIONAL: static assertion failed: ProbeContext_size_matches_ctiMasmProbeTrampoline

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

See https://bugs.webkit.org/show_bug.cgi?id=175446#c23.

[Mark Lam]

(In reply to Csaba Osztrogonác_OOO_until_21st_Aug from comment #23 @ https://bugs.webkit.org/show_bug.cgi?id=175446#c23)
> and it broke the ARMv7 (traditional) build too:
> ../../Source/JavaScriptCore/assembler/MacroAssemblerARM.cpp:203:1: error:
> static assertion failed: ProbeContext_size_matches_ctiMasmProbeTrampoline

@Ossy, I cannot fixed / diagnose this issue since I don't have the means to build for traditional ARM.  This static_assert failure here is saying that sizeof(ProbeContext) is not our expected value, 208.  Can you check what sizeof(ProbeContext) is on ARM_TRADITIONAL?

[Csaba Osztrogonác]

(In reply to Mark Lam from comment #1)
> (In reply to Csaba Osztrogonác_OOO_until_21st_Aug from comment #23 @
> https://bugs.webkit.org/show_bug.cgi?id=175446#c23)
> > and it broke the ARMv7 (traditional) build too:
> > ../../Source/JavaScriptCore/assembler/MacroAssemblerARM.cpp:203:1: error:
> > static assertion failed: ProbeContext_size_matches_ctiMasmProbeTrampoline
> 
> @Ossy, I cannot fixed / diagnose this issue since I don't have the means to
> build for traditional ARM.  This static_assert failure here is saying that
> sizeof(ProbeContext) is not our expected value, 208.  Can you check what
> sizeof(ProbeContext) is on ARM_TRADITIONAL?

sizeof(ProbeContext) is 336. Where should I search the root of this issue?

[Csaba Osztrogonác]

(In reply to Csaba Osztrogonác_OOO_until_21st_Aug from comment #2)
> (In reply to Mark Lam from comment #1)
> > (In reply to Csaba Osztrogonác_OOO_until_21st_Aug from comment #23 @
> > https://bugs.webkit.org/show_bug.cgi?id=175446#c23)
> > > and it broke the ARMv7 (traditional) build too:
> > > ../../Source/JavaScriptCore/assembler/MacroAssemblerARM.cpp:203:1: error:
> > > static assertion failed: ProbeContext_size_matches_ctiMasmProbeTrampoline
> > 
> > @Ossy, I cannot fixed / diagnose this issue since I don't have the means to
> > build for traditional ARM.  This static_assert failure here is saying that
> > sizeof(ProbeContext) is not our expected value, 208.  Can you check what
> > sizeof(ProbeContext) is on ARM_TRADITIONAL?
> 
> sizeof(ProbeContext) is 336. Where should I search the root of this issue?

I think I got the root of the problem. There are 32 FP registers, but
only d0-d15 are saved, that's why sizeof(ProbeContext) is 336, not 208.

[Csaba Osztrogonác]

fix is coming

[Csaba Osztrogonác]

Created attachment 318002 [details]
Patch

build works, tests are still running

[Mark Lam]

Comment on attachment 318002 [details]
Patch

r=me

[Csaba Osztrogonác]

Comment on attachment 318002 [details]
Patch

Tests pass, let's land it.

[WebKit Commit Bot]

Comment on attachment 318002 [details]
Patch

Clearing flags on attachment: 318002

Committed r220629: <http://trac.webkit.org/changeset/220629>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33866212>