Bug 175509 – [iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToContentEditable that doesn't hit a debug assertion

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Wenson Hsieh]

This test is hitting a debug assertion after a recent SDK update. Instead of using [UIFont boldSystemFontOfSize:] to test that attributed strings preserve styles when dropping, use a foreground color and check that the resulting inserted text is colored in the DOM.

[Wenson Hsieh]

<rdar://problem/33728169>

[Wenson Hsieh]

Created attachment 317993 [details]
Patch

[Megan Gardner]

This looks good, minus it not working on iOS-sim. I thought that the call you switched to might be too new for the perf bots, but it seems to be fine.

[Wenson Hsieh]

(In reply to Megan Gardner from comment #3)
> This looks good, minus it not working on iOS-sim. I thought that the call
> you switched to might be too new for the perf bots, but it seems to be fine.

Thanks for taking a look!

Unfortunately, these API tests are not run on the EWS bots at all. The test failures making 'ios-sim' orange in the dashboard are unrelated:

- imported/w3c/web-platform-tests/fetch/
- imported/w3c/web-platform-tests/cors/
- imported/w3c/web-platform-tests/XMLHttpRequest/
- imported/w3c/web-platform-tests/beacon/
- http/tests/blink/sendbeacon/
- http/wpt/beacon/

[Megan Gardner]

Oh, I forgot that they don't run. LGTM then!

(In reply to Wenson Hsieh from comment #4)
> (In reply to Megan Gardner from comment #3)
> > This looks good, minus it not working on iOS-sim. I thought that the call
> > you switched to might be too new for the perf bots, but it seems to be fine.
> 
> Thanks for taking a look!
> 
> Unfortunately, these API tests are not run on the EWS bots at all. The test
> failures making 'ios-sim' orange in the dashboard are unrelated:
> 
> - imported/w3c/web-platform-tests/fetch/
> - imported/w3c/web-platform-tests/cors/
> - imported/w3c/web-platform-tests/XMLHttpRequest/
> - imported/w3c/web-platform-tests/beacon/
> - http/tests/blink/sendbeacon/
> - http/wpt/beacon/

[Wenson Hsieh]

Created attachment 318536 [details]
Patch

[Wenson Hsieh]

Tim and I chatted in person -- we're going to keep the debug-assertion-ing test, but mark it as disabled, and add a new test that fulfills the same purpose (w.r.t. testing attributed strings and DnD) but uses color instead to ensure that we don't leave this codepath untested.

[Ryosuke Niwa]

Comment on attachment 318536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318536&action=review

> Tools/ChangeLog:11
> +        Clone ExternalSourceAttributedStringToContentEditable to ExternalSourceColoredAttributedStringToContentEditable,
> +        which tests an attributed string with colored text instead of a bold attributed string of system font. Due to a
> +        recent change in behavior in UIKit, this test is hitting a debug assertion. The purpose of this test is to verify

Could you clarify that you're adding a test which changes color because bold case is crashing.

[Wenson Hsieh]

Comment on attachment 318536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318536&action=review

>> Tools/ChangeLog:11
>> +        recent change in behavior in UIKit, this test is hitting a debug assertion. The purpose of this test is to verify
> 
> Could you clarify that you're adding a test which changes color because bold case is crashing.

Will do!

[Wenson Hsieh]

Created attachment 318584 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 318584 [details]
Patch for landing

Clearing flags on attachment: 318584

Committed r220952: <http://trac.webkit.org/changeset/220952>