Bug 175492 - Merge JSLexicalEnvironment and JSEnvironmentRecord
Summary: Merge JSLexicalEnvironment and JSEnvironmentRecord
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-11 13:49 PDT by Filip Pizlo
Modified: 2017-09-27 12:59 PDT (History)
5 users (show)

See Also:

Attachments
Patch (45.60 KB, patch)
2017-09-17 08:23 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-08-11 13:49:48 PDT 
It looks like these are used as one type, since JSEnvironmentRecord is abstract and its only implementation is JSLexicalEnvironment.
Comment 1 Yusuke Suzuki 2017-09-17 08:17:30 PDT 
I would like to optimize toThis() operation. Before doing this, we would like to drop JSEnvironmentRecord.
Comment 2 Yusuke Suzuki 2017-09-17 08:23:45 PDT 
Created attachment 321044 [details]
Patch
Comment 3 Yusuke Suzuki 2017-09-17 10:28:20 PDT 
Committed r222136: <http://trac.webkit.org/changeset/222136>
Comment 4 Radar WebKit Bug Importer 2017-09-27 12:59:15 PDT 
<rdar://problem/34694427>