.
Created attachment 317930 [details] Patch
Comment on attachment 317930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317930&action=review > LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt:7 > +FAIL ':in-range' matches all elements that are candidates for constraint validation, have range limitations, and that are neither suffering from an underflow nor suffering from an overflow assert_array_equals: lengths differ, expected 10 got 5 > +FAIL ':out-of-range' matches all elements that are candidates for constraint validation, have range limitations, and that are either suffering from an underflow or suffering from an overflow assert_array_equals: lengths differ, expected 12 got 2 > +FAIL ':in-range' update number1's value < min assert_array_equals: lengths differ, expected 9 got 4 > +FAIL ':out-of-range' update number1's value < min assert_array_equals: lengths differ, expected 13 got 3 > +FAIL ':in-range' update number3's min < value assert_array_equals: lengths differ, expected 10 got 5 > +FAIL ':out-of-range' update number3's min < value assert_array_equals: lengths differ, expected 12 got 2 Why is this expected behavior?
That's actually kind of odd. The only difference between this file and the platform-neutral expectation file is the whitespace at the end. I have no idea where it comes from.
OK, then it's fine. Youenn accepts lots of FAILS is our web platform tests expectations since it's still useful to catch unexpected behavior changes. I'd just prefer to not have them in GTK-specific expectations as that's not how we track bugs on our port.
Comment on attachment 317930 [details] Patch Clearing flags on attachment: 317930 Committed r220655: <http://trac.webkit.org/changeset/220655>
All reviewed patches have been landed. Closing bug.