Bug 17548 - JavaScriptCore print(a, b) differs from Spidermonkey Behavior
Summary: JavaScriptCore print(a, b) differs from Spidermonkey Behavior
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-25 23:29 PST by Brent Fulgham
Modified: 2008-06-07 14:58 PDT (History)
0 users

See Also:

Attachments
Proposed patch (1.36 KB, patch)
2008-06-07 14:04 PDT, Cameron Zwarich (cpst) 		no flags Details | Formatted Diff | Diff
Revised proposed patch (1.20 KB, patch)
2008-06-07 14:51 PDT, Cameron Zwarich (cpst) 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2008-02-25 23:29:22 PST 
Spidermonkey allows comma-separated arguments to print.  These values are printed with a space inbetween.

This:
print ("foo", "bar")

Produces:
foo bar

In JavaScriptCore it produces:
foo
Comment 1 Cameron Zwarich (cpst) 2008-06-07 14:04:35 PDT 
Created attachment 21565 [details]
Proposed patch

Here is a patch. It uses indices instead of iterators because our iterators don't have a distance function.
Comment 2 Cameron Zwarich (cpst) 2008-06-07 14:51:27 PDT 
Created attachment 21566 [details]
Revised proposed patch

Includes some changes suggested by Eric.
Comment 3 Eric Seidel (no email) 2008-06-07 14:52:40 PDT 
Comment on attachment 21566 [details]
Revised proposed patch

Looks great!  (I think I even wrote work-around code in some test cases instead of fixing this once.)
Comment 4 Cameron Zwarich (cpst) 2008-06-07 14:58:09 PDT 
Landed in r34429.