RESOLVED FIXED 175475
[CMake] Many warnings about missing “override” keywords in ANGLE with Clang 
https://bugs.webkit.org/show_bug.cgi?id=175475
Summary [CMake] Many warnings about missing “override” keywords in ANGLE with Clang
Adrian Perez
Reported 2017-08-11 03:24:14 PDT
Currently building ANGLE as part of WebCore with Clang spews a good bunch of warnings similar to the following one: In file included from ../../Source/ThirdParty/ANGLE/src/compiler/translator/UniformHLSL.cpp:10: In file included from ../../Source/ThirdParty/ANGLE/src/compiler/translator/UniformHLSL.h:13: ../../Source/ThirdParty/ANGLE/src/compiler/translator/OutputHLSL.h:86:10: warning: 'visitBranch' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] bool visitBranch(Visit visit, TIntermBranch *); ^ ../../Source/ThirdParty/ANGLE/src/compiler/translator/IntermNode.h:957:18: note: overridden virtual function is here virtual bool visitBranch(Visit visit, TIntermBranch *node) { return true; } ^ As ANGLE is third-party code, let's to pass “-Wno-inconsistent-missing-override” when building its sources.
Attachments
Patch (1.49 KB, patch)
2017-08-11 03:27 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2017-08-11 03:27:11 PDT
Created attachment 317923 [details] Patch
WebKit Commit Bot
Comment 2 2017-08-11 08:44:04 PDT
Comment on attachment 317923 [details] Patch Clearing flags on attachment: 317923 Committed r220591: <http://trac.webkit.org/changeset/220591>
WebKit Commit Bot
Comment 3 2017-08-11 08:44:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.