Bug 175474 – Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

Replace the build flag for dataTransfer.items by a runtime flag and add stub implementation to make it compile.

[Radar WebKit Bug Importer]

<rdar://problem/33844628>

[Ryosuke Niwa]

Created attachment 317921 [details]
Patch

[Wenson Hsieh]

Comment on attachment 317921 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317921&action=review

LGTM with some minor comments. This might need a wk2r+ as well. Can we also write a quick LayoutTest to check that we can reference items on a DataTransfer?

> ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=175474

If there's a corresponding radar, let's include it in the ChangeLogs.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:-18606
> -				51F175001F358B3600C74950 /* JSServiceWorkerUpdateViaCache.cpp */,

Are these changes intended?

> Source/WebCore/dom/DataTransferItemList.h:49
> +    { }

Nit - most other classes in WebCore use a style like:

{
}

in the constructor, even when the constructor is empty.

[Ryosuke Niwa]

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 317921 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=317921&action=review
> 
> LGTM with some minor comments. This might need a wk2r+ as well. Can we also
> write a quick LayoutTest to check that we can reference items on a
> DataTransfer?

I was gonna say W3C surely has a test for this but they don't :( Adding a new IDL test.

> > ChangeLog:4
> > +        https://bugs.webkit.org/show_bug.cgi?id=175474
> 
> If there's a corresponding radar, let's include it in the ChangeLogs.

Added. But it doesn't really matter at this point in time since bug URL is enough to find the radar. It only starts to matter with changes that get merged into branches, or near the branching points. I guess I'm gonna stop importing to radar now that all closed bugs will create a radar automatically after the fact.

> > Source/WebCore/WebCore.xcodeproj/project.pbxproj:-18606
> > -				51F175001F358B3600C74950 /* JSServiceWorkerUpdateViaCache.cpp */,
> 
> Are these changes intended?

Well, it's expected that these changes happen now that webkit-patch auto sorts xcodeproj files.

> > Source/WebCore/dom/DataTransferItemList.h:49
> > +    { }
> 
> Nit - most other classes in WebCore use a style like:
> 
> {
> }
> 
> in the constructor, even when the constructor is empty.

Fixed.

[Ryosuke Niwa]

Created attachment 317936 [details]
Added an IDL test

[Wenson Hsieh]

Comment on attachment 317936 [details]
Added an IDL test

View in context: https://bugs.webkit.org/attachment.cgi?id=317936&action=review

> Source/WebCore/dom/DataTransferItem.cpp:46
> +

Nit - Extra newline here.

[Ryosuke Niwa]

Created attachment 318000 [details]
Patch for landing

[Ryosuke Niwa]

Committed r220627: <http://trac.webkit.org/changeset/220627>