Bug 175468 - [GTK] stop kinetic scrolling when a zero movement is reached
Summary: [GTK] stop kinetic scrolling when a zero movement is reached
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-10 18:22 PDT by Christian Hergert
Modified: 2017-08-13 23:23 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.22 KB, patch)
2017-08-11 06:33 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Hergert 2017-08-10 18:22:24 PDT
When the kinetic scrolling reduces it's speed, there can be multiple frames where the movement is zero pixels (followed by a 1 pixel movement later on).

This causes a "jitter" right at the end of the scroll which makes it feel less quality than other platforms. Instead, we should just clamp it as soon as we get a zero movement.

This is what I put in Gtk+ to avoid the same issue.

  https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-22&id=4f63d839550f7a9038b391e7d3e1e6fc8bdfafa6
Comment 1 Carlos Garcia Campos 2017-08-11 06:33:50 PDT
Created attachment 317927 [details]
Patch

Thank you Christian!
Comment 2 Carlos Garcia Campos 2017-08-13 23:23:43 PDT
Committed r220638: <http://trac.webkit.org/changeset/220638>