Bug 175467 - Fix the build with modern Clang's -Wexpansion-to-defined
Summary: Fix the build with modern Clang's -Wexpansion-to-defined
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-10 17:50 PDT by Tim Horton
Modified: 2017-08-11 15:35 PDT (History)
16 users (show)

See Also:


Attachments
Patch (3.16 KB, patch)
2017-08-10 17:50 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.02 MB, application/zip)
2017-08-10 19:32 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews115 for mac-elcapitan (1.92 MB, application/zip)
2017-08-10 19:58 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.93 MB, application/zip)
2017-08-10 20:13 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.53 MB, application/zip)
2017-08-10 22:14 PDT, Build Bot
no flags Details
Patch (4.16 KB, patch)
2017-08-11 14:29 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (4.33 KB, patch)
2017-08-11 14:37 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-08-10 17:50:09 PDT
Fix the build with modern Clang's -Wexpansion-to-defined
Comment 1 Tim Horton 2017-08-10 17:50:54 PDT
Created attachment 317895 [details]
Patch
Comment 2 Build Bot 2017-08-10 18:47:11 PDT Comment hidden (obsolete)
Comment 3 Tim Horton 2017-08-10 18:53:22 PDT
What.
Comment 4 Tim Horton 2017-08-10 18:56:04 PDT
Huh, these are oddly circular!

#if ENABLE(FTL_JIT) || ENABLE(WEBASSEMBLY)
#define ENABLE_B3_JIT 1
#endif


#define ENABLE_WEBASSEMBLY (defined(ENABLE_B3_JIT) && ENABLE_B3_JIT)
Comment 5 Build Bot 2017-08-10 19:32:44 PDT Comment hidden (obsolete)
Comment 6 Build Bot 2017-08-10 19:32:46 PDT Comment hidden (obsolete)
Comment 7 Build Bot 2017-08-10 19:57:59 PDT Comment hidden (obsolete)
Comment 8 Build Bot 2017-08-10 19:58:01 PDT Comment hidden (obsolete)
Comment 9 Build Bot 2017-08-10 20:13:22 PDT Comment hidden (obsolete)
Comment 10 Build Bot 2017-08-10 20:13:24 PDT Comment hidden (obsolete)
Comment 11 Build Bot 2017-08-10 22:14:00 PDT Comment hidden (obsolete)
Comment 12 Build Bot 2017-08-10 22:14:02 PDT Comment hidden (obsolete)
Comment 13 Tim Horton 2017-08-11 14:29:46 PDT
Created attachment 317962 [details]
Patch
Comment 14 Tim Horton 2017-08-11 14:37:14 PDT
Created attachment 317964 [details]
Patch
Comment 15 WebKit Commit Bot 2017-08-11 15:35:34 PDT
Comment on attachment 317964 [details]
Patch

Clearing flags on attachment: 317964

Committed r220615: <http://trac.webkit.org/changeset/220615>
Comment 16 WebKit Commit Bot 2017-08-11 15:35:36 PDT
All reviewed patches have been landed.  Closing bug.