Bug 175452 – Web Inspector: Ensure three.js gets minified properly

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Ross Kirsling]

After three.js source is added to Source/WebInspectorUI/UserInterface/External, we must make sure these files are properly minified for release builds.

[Ross Kirsling]

Created attachment 318064 [details]
Patch

[Ross Kirsling]

Comment on attachment 318064 [details]
Patch

Misspoke in my previous comment:
Release != production; this is for production builds only.

The three.js files haven't yet been added to Main.html, so this currently just spits out the license, but I confirmed that behavior is as expected when Main.html is updated (using copy-user-interface-resources-dryrun.rb).

[Build Bot]

Comment on attachment 318064 [details]
Patch

Attachment 318064 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4315472

New failing tests:
imported/w3c/web-platform-tests/custom-elements/microtasks-and-constructors.html

[Build Bot]

Created attachment 318106 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Ross Kirsling]

Hopefully it goes without saying that this patch has nothing to do with ios-sim layout tests.
That issue is already reported here: https://bugs.webkit.org/show_bug.cgi?id=172732

[Blaze Burg]

Comment on attachment 318064 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 318064 [details]
Patch

Clearing flags on attachment: 318064

Committed r220873: <http://trac.webkit.org/changeset/220873>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33948519>

[Joseph Pecoraro]

Comment on attachment 318064 [details]
Patch

On lines 308 and 309 we exclude ESLint.js until it is needed. Should we do the same here or are we going to imminently use it?

[Ross Kirsling]

Good question. I could open a new ticket right now to land the current WIP Patch in https://bugs.webkit.org/show_bug.cgi?id=174176 as a stage-one commit for the Layers tab, if this sounds acceptable to you guys? But if we're not ready for that, then we should temporarily add an exclusion.