Bug 175448 – Web Inspector: add filter for draw actions in Recordings

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

We are already able to filter by name, but we currently can't filter by "designation"/"category".  Filtering by whether the action draws would be great.  This could be done similar to how Debugger has "Only show resources with issues".

[Radar WebKit Bug Importer]

<rdar://problem/34040764>

[Devin Rousso]

Created attachment 318923 [details]
Patch

[Devin Rousso]

Created attachment 318924 [details]
[Image] After Patch is applied

[Matt Baker]

We should remove the visual change highlight when the filter is active.

[Devin Rousso]

(In reply to Matt Baker from comment #4)
> We should remove the visual change highlight when the filter is active.
I think that would be more confusing.  I would expect filtering to just show/hide, not change any shown UI.

[Matt Baker]

Comment on attachment 318923 [details]
Patch

r=me, just need to figure out what's causing the build failure on wpe.

[Matt Baker]

The problem is with the way WPE handles dependencies.

WebKit/PlatformWPE.cmake:435:
set(InspectorFiles
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/*.html
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Base/*.js
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Controllers/*.css
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Controllers/*.js
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Debug/*.css
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Debug/*.js
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/External/CodeMirror/*.css
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/External/CodeMirror/*.js
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/External/ESLint/*.js
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/External/Esprima/*.js
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Images/gtk/*.png
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Images/gtk/*.svg
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Models/*.js
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Protocol/*.js
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Proxies/*.js
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Test/*.js
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Views/*.css
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Views/*.js
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Workers/Formatter/*.js
    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Workers/HeapSnapshot/*.js
)

file(GLOB InspectorFilesDependencies
    ${InspectorFiles}
)

InspectorGResourceBundle.xml is only regenerated when CMake runs, which will be never, since CMakeLists.txt isn't changing. WPE will break whenever an Inspector file is renamed, and won't pick up newly added files either.

[Matt Baker]

This is a known issue, and I've contacted a couple of WPE maintainers to remind them. Since this just effects EWS, no need to wait for a resolution.

[WebKit Commit Bot]

Comment on attachment 318923 [details]
Patch

Clearing flags on attachment: 318923

Committed r221174: <http://trac.webkit.org/changeset/221174>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.