Bug 175442 - Resource Load Statistics: Add significant figures to telemetry calls
Summary: Resource Load Statistics: Add significant figures to telemetry calls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-10 13:54 PDT by John Wilander
Modified: 2017-08-10 17:41 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.86 KB, patch)
2017-08-10 14:10 PDT, John Wilander
no flags Details | Formatted Diff | Diff
Patch (5.86 KB, patch)
2017-08-10 14:47 PDT, John Wilander
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2017-08-10 13:54:18 PDT
The significant figures parameter is currently set to 0 in Resource Load Statistics' telemetry calls (a mistake). It should be large enough to cover the statistical values we have. I suggest 6 significant figures since it allows values up to 999999. The number of entries is capped to 1000 so it's likely the number of times data records have been removed that's going to be the largest value. 999999 / 24 / 365.25 > 114 years if data records are removed once an hour around the clock.
Comment 1 Radar WebKit Bug Importer 2017-08-10 13:54:41 PDT
<rdar://problem/33834834>
Comment 2 John Wilander 2017-08-10 14:10:55 PDT
Created attachment 317842 [details]
Patch
Comment 3 John Wilander 2017-08-10 14:42:50 PDT
New patch coming. We should lower this to three significant figures since that only zeroes out the rest which is fine.
Comment 4 John Wilander 2017-08-10 14:47:01 PDT
Created attachment 317852 [details]
Patch
Comment 5 Brent Fulgham 2017-08-10 17:09:22 PDT
Comment on attachment 317852 [details]
Patch

r=me.
Comment 6 John Wilander 2017-08-10 17:10:22 PDT
Comment on attachment 317852 [details]
Patch

Thanks, Brent!
Comment 7 WebKit Commit Bot 2017-08-10 17:41:12 PDT
Comment on attachment 317852 [details]
Patch

Clearing flags on attachment: 317852

Committed r220568: <http://trac.webkit.org/changeset/220568>
Comment 8 WebKit Commit Bot 2017-08-10 17:41:14 PDT
All reviewed patches have been landed.  Closing bug.