RESOLVED FIXED 175442
Resource Load Statistics: Add significant figures to telemetry calls 
https://bugs.webkit.org/show_bug.cgi?id=175442
Summary Resource Load Statistics: Add significant figures to telemetry calls
John Wilander
Reported 2017-08-10 13:54:18 PDT
The significant figures parameter is currently set to 0 in Resource Load Statistics' telemetry calls (a mistake). It should be large enough to cover the statistical values we have. I suggest 6 significant figures since it allows values up to 999999. The number of entries is capped to 1000 so it's likely the number of times data records have been removed that's going to be the largest value. 999999 / 24 / 365.25 > 114 years if data records are removed once an hour around the clock.
Attachments
Patch (5.86 KB, patch)
2017-08-10 14:10 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Patch (5.86 KB, patch)
2017-08-10 14:47 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-08-10 13:54:41 PDT
<rdar://problem/33834834>
John Wilander
Comment 2 2017-08-10 14:10:55 PDT
Created attachment 317842 [details] Patch
John Wilander
Comment 3 2017-08-10 14:42:50 PDT
New patch coming. We should lower this to three significant figures since that only zeroes out the rest which is fine.
John Wilander
Comment 4 2017-08-10 14:47:01 PDT
Created attachment 317852 [details] Patch
Brent Fulgham
Comment 5 2017-08-10 17:09:22 PDT
Comment on attachment 317852 [details] Patch r=me.
John Wilander
Comment 6 2017-08-10 17:10:22 PDT
Comment on attachment 317852 [details] Patch Thanks, Brent!
WebKit Commit Bot
Comment 7 2017-08-10 17:41:12 PDT
Comment on attachment 317852 [details] Patch Clearing flags on attachment: 317852 Committed r220568: <http://trac.webkit.org/changeset/220568>
WebKit Commit Bot
Comment 8 2017-08-10 17:41:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.