These changes came about from noticing that VM::m_perBytecodeProfiler is only used when Options::useProfiler() is true. Options::useProfiler() is false by default.
<rdar://problem/33834767>
Created attachment 317843 [details] proposed patch.
Attachment 317843 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:147: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 317843 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=317843&action=review r=me > Source/JavaScriptCore/bytecode/CodeBlock.cpp:1920 > + if (UNLIKELY(Profiler::Compilation* compilation = jitCode()->dfgCommon()->compilation.get())) IIRC, this does not work in some platforms (it causes compiling error). `if (UNLIKELY(Type x = ...))` Please check EWS. If EWS becomes green, ignore this comment :) > Source/JavaScriptCore/ftl/FTLLink.cpp:71 > + if (UNLIKELY(Profiler::Compilation* compilation = graph.compilation())) { Ditto. > Source/JavaScriptCore/runtime/ScriptExecutable.cpp:160 > + if (UNLIKELY(Debugger* debugger = genericCodeBlock->globalObject()->debugger())) Ditto.
Thanks for the review. I've fixed the issues, and will retest on EWS.
Created attachment 317848 [details] patch for landing.
Attachment 317848 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:147: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 317848 [details] patch for landing. Clearing flags on attachment: 317848 Committed r220556: <http://trac.webkit.org/changeset/220556>
All reviewed patches have been landed. Closing bug.