Bug 175419 - [GTK] Several service-workers related tests are failing
Summary: [GTK] Several service-workers related tests are failing
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Gtk (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 178576
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-10 02:11 PDT by Miguel Gomez
Modified: 2018-11-01 07:41 PDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2017-08-10 02:11:58 PDT
Service-workers implementation is not complete yet. Some tests are skipped at the general TestExpectations, but those related to cache-storage are already unskipped for mac. These are:

imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-add.https.html [ Failure ]
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-delete.https.html [ Failure ]
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-keys.https.html [ Failure ]
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html [ Failure ]
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-matchAll.https.html [ Failure ]
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https.html [ Failure ]
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-keys.https.html [ Failure ]
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-match.https.html [ Failure ]
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage.https.html [ Failure ]

These tests were added in r220311. I'm skipping that directory in the gtk TestExpectations.
Comment 1 Miguel Gomez 2017-08-10 02:28:27 PDT
And more service-worker related tests failing, these since r220270 where their expectations were changed:

imported/w3c/web-platform-tests/background-fetch/interfaces-worker.https.html [ Failure ]
imported/w3c/web-platform-tests/background-fetch/interfaces.html [ Failure ]
imported/w3c/web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https.html [ Failure ]
imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https.html [ Failure ]
imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https.html [ Failure ]
imported/w3c/web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https.html [ Failure ]
imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https.html [ Failure ]
imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/byte-length-queuing-strategy.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/count-queuing-strategy.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/piping/close-propagation-backward.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/piping/close-propagation-forward.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/piping/error-propagation-backward.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/piping/flow-control.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/piping/general.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/piping/multiple-propagation.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/piping/pipe-through.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/piping/transform-streams.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/brand-checks.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/cancel.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/default-reader.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/floating-point-total-queue-size.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/general.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/pipe-through.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/readable-stream-reader.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/tee.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-streams/templated.serviceworker.https.html [ Failure ]
imported/w3c/web-platform-tests/streams/readable-byte-streams/general.serviceworker.https.html [ Failure ]
Comment 2 Frédéric Wang (:fredw) 2018-10-02 09:02:47 PDT
The failing tests are now:

http/tests/workers/service/controller-change.html
http/tests/workers/service/no-page-cache-when-controlled.html
http/wpt/service-workers/persistent-importScripts.html
imported/w3c/web-platform-tests/service-workers/service-worker/activation.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/claim-with-redirect.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/registration-script.https.html [ 
imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-without-client.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting.https.html

It seems most of them are related to an assertion failure:
ERROR: ResourceLoadStatisticsPersistentStorage: Unable to delete statistics file: /tmp/WebKitTestRunners-maRQFU/ResourceLoadStatistics/full_browsing_session_resourceLog.plist
../../Source/WebKit/UIProcess/ResourceLoadStatisticsPersistentStorage.cpp(311) : void WebKit::ResourceLoadStatisticsPersistentStorage::clear()
ASSERTION FAILED: m_ptr
Comment 3 Michael Catanzaro 2018-10-02 10:19:03 PDT
We should really take the time to implement resource load statistics.
Comment 4 Miguel Gomez 2018-10-18 07:10:42 PDT
imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache-storage-match.https.html [ Crash ]
imported/w3c/web-platform-tests/service-workers/cache-storage/worker/cache-storage-match.https.html [ Crash ]
Comment 5 Michael Catanzaro 2018-10-27 17:58:13 PDT
One more that was missed:

imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-match.https.html [ Failure ]
Comment 6 Michael Catanzaro 2018-10-27 17:59:45 PDT
Also:

imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/credentials.https.html [ Failure ]
Comment 7 Claudio Saavedra 2018-11-01 07:41:10 PDT
(In reply to Frédéric Wang (:fredw) from comment #2)

> It seems most of them are related to an assertion failure:
> ERROR: ResourceLoadStatisticsPersistentStorage: Unable to delete statistics
> file:
> /tmp/WebKitTestRunners-maRQFU/ResourceLoadStatistics/
> full_browsing_session_resourceLog.plist
> ../../Source/WebKit/UIProcess/ResourceLoadStatisticsPersistentStorage.
> cpp(311) : void WebKit::ResourceLoadStatisticsPersistentStorage::clear()


I filed https://bugs.webkit.org/show_bug.cgi?id=191152 about this error.