Bug 175409 – Web Inspector: Clicking on suggestion hint should apply it, not dismiss

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Created attachment 317757 [details]
[Animated GIF] Bug

In Console prompt and Styles sidebar, clicking on the suggestion hint (the gray text), discards the suggestion hint.

It should instead apply the suggestion hint.

[Nikita Vasilyev]

Created attachment 317758 [details]
Patch

[Nikita Vasilyev]

Comment on attachment 317758 [details]
Patch

This doesn't in Styles.

[Nikita Vasilyev]

Created attachment 317760 [details]
Patch

[Nikita Vasilyev]

Created attachment 317762 [details]
[Animated GIF] With patch applied

(In reply to Nikita Vasilyev from comment #2)
> Comment on attachment 317758 [details]
> Patch
> 
> This doesn't in Styles.

This doesn't WORK in Styles.

[Nikita Vasilyev]

To clarify, the last patch works in both console and styles.

[Matt Baker]

Comment on attachment 317760 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317760&action=review

> Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:259
> +            setTimeout(() => { this._codeMirror.focus() }, 1);

Is there a reason the delay isn't zero?

[Nikita Vasilyev]

(In reply to Matt Baker from comment #6)
> Comment on attachment 317760 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=317760&action=review
> 
> > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:259
> > +            setTimeout(() => { this._codeMirror.focus() }, 1);
> 
> Is there a reason the delay isn't zero?

No reason. I see we usually use 0, I'll change it for consistency.

[Nikita Vasilyev]

Created attachment 317966 [details]
Patch

[Matt Baker]

Comment on attachment 317966 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 317966 [details]
Patch

Clearing flags on attachment: 317966

Committed r220614: <http://trac.webkit.org/changeset/220614>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33857544>