Created attachment 317757 [details] [Animated GIF] Bug In Console prompt and Styles sidebar, clicking on the suggestion hint (the gray text), discards the suggestion hint. It should instead apply the suggestion hint.
Created attachment 317758 [details] Patch
Comment on attachment 317758 [details] Patch This doesn't in Styles.
Created attachment 317760 [details] Patch
Created attachment 317762 [details] [Animated GIF] With patch applied (In reply to Nikita Vasilyev from comment #2) > Comment on attachment 317758 [details] > Patch > > This doesn't in Styles. This doesn't WORK in Styles.
To clarify, the last patch works in both console and styles.
Comment on attachment 317760 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317760&action=review > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:259 > + setTimeout(() => { this._codeMirror.focus() }, 1); Is there a reason the delay isn't zero?
(In reply to Matt Baker from comment #6) > Comment on attachment 317760 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=317760&action=review > > > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:259 > > + setTimeout(() => { this._codeMirror.focus() }, 1); > > Is there a reason the delay isn't zero? No reason. I see we usually use 0, I'll change it for consistency.
Created attachment 317966 [details] Patch
Comment on attachment 317966 [details] Patch r=me
Comment on attachment 317966 [details] Patch Clearing flags on attachment: 317966 Committed r220614: <http://trac.webkit.org/changeset/220614>
All reviewed patches have been landed. Closing bug.
<rdar://problem/33857544>