Bug 175394 - [Bindings] Simplify DOMPromiseProxy now that WTF::Function can return references
Summary: [Bindings] Simplify DOMPromiseProxy now that WTF::Function can return references
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-09 13:10 PDT by Sam Weinig
Modified: 2017-08-11 17:32 PDT (History)
4 users (show)

See Also:

Attachments
Patch (12.56 KB, patch)
2017-08-09 13:17 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (12.54 KB, patch)
2017-08-09 14:13 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-08-09 13:10:58 PDT 
[Bindings] Simplify DOMPromiseProxy now that WTF::Function can return references
Comment 1 Sam Weinig 2017-08-09 13:17:12 PDT 
Created attachment 317731 [details]
Patch
Comment 2 Build Bot 2017-08-09 13:19:33 PDT 
Attachment 317731 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/DOMPromiseProxy.h:87:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2017-08-09 14:13:05 PDT 
Created attachment 317739 [details]
Patch
Comment 4 Build Bot 2017-08-09 14:15:59 PDT 
Attachment 317739 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/DOMPromiseProxy.h:87:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Commit Bot 2017-08-11 17:32:06 PDT 
Comment on attachment 317739 [details]
Patch

Clearing flags on attachment: 317739

Committed r220620: <http://trac.webkit.org/changeset/220620>
Comment 6 WebKit Commit Bot 2017-08-11 17:32:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-08-11 17:32:39 PDT 
<rdar://problem/33859548>