Bug 175391 – Teach ScriptExecutionContexts about their SessionID

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Teach ScriptExecutionContexts about their SessionID

Especially needed to expose SessionIDs to workers.

[Brady Eidson]

Created attachment 317726 [details]
Patch

[Andy Estes]

Comment on attachment 317726 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317726&action=review

> Source/WebCore/page/SessionID.cpp:61
> +SessionID SessionID::isolatedCopy() const
> +{
> +    return SessionID { m_sessionID };
> +}

Seems like you could just do a regular copy-by-value in WorkerThreadStartupData instead of adding this, since there's no actual isolated copying going on here.

[Brady Eidson]

(In reply to Andy Estes from comment #2)
> Comment on attachment 317726 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=317726&action=review
> 
> > Source/WebCore/page/SessionID.cpp:61
> > +SessionID SessionID::isolatedCopy() const
> > +{
> > +    return SessionID { m_sessionID };
> > +}
> 
> Seems like you could just do a regular copy-by-value in
> WorkerThreadStartupData instead of adding this, since there's no actual
> isolated copying going on here.

I much prefer future proofing (future resisting?) any class that is passed cross thread.

By having isolatedCopy() in the SessionID.h header, it suggests to anybody adding any future arguments that they need to account for them.

[Brady Eidson]

(In reply to Brady Eidson from comment #3)
> (In reply to Andy Estes from comment #2)
> > Comment on attachment 317726 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=317726&action=review
> > 
> > > Source/WebCore/page/SessionID.cpp:61
> > > +SessionID SessionID::isolatedCopy() const
> > > +{
> > > +    return SessionID { m_sessionID };
> > > +}
> > 
> > Seems like you could just do a regular copy-by-value in
> > WorkerThreadStartupData instead of adding this, since there's no actual
> > isolated copying going on here.
> 
> I much prefer future proofing (future resisting?) any class that is passed
> cross thread.
> 
> By having isolatedCopy() in the SessionID.h header, it suggests to anybody
> adding any future arguments that they need to account for them.

s/future arguments/future members/

[WebKit Commit Bot]

Comment on attachment 317726 [details]
Patch

Clearing flags on attachment: 317726

Committed r220475: <http://trac.webkit.org/changeset/220475>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33809118>