LayoutTest http/wpt/beacon/keepalive-after-navigation.html is a flaky failure (harness timeout) https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/3466 https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fbeacon%2Fkeepalive-after-navigation.html --- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/http/wpt/beacon/keepalive-after-navigation-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/http/wpt/beacon/keepalive-after-navigation-actual.txt @@ -1,4 +1,6 @@ frame "testFrame" - has 1 onunload handler(s) -PASS Test that beacon sent from unload event handler is properly received +Harness Error (TIMEOUT), message = null +TIMEOUT Test that beacon sent from unload event handler is properly received Test timed out +
Created attachment 317716 [details] Patch
Comment on attachment 317716 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317716&action=review > LayoutTests/imported/w3c/web-platform-tests/beacon/beacon-navigate.html:12 > + <script src="beacon-common.js?pipe=sub"></script> Style only but it would be nicer to rename beacon-common.js as beacon-common.sub.js and remove the ?pipe=sub Looking at beacon-common.js, the polling mechanism seems fine. I would tend though to stop polling and raise an error after a long timeout like 5 seconds but I am not sure how WPT would like that change.
(In reply to youenn fablet from comment #2) > Comment on attachment 317716 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=317716&action=review > > > LayoutTests/imported/w3c/web-platform-tests/beacon/beacon-navigate.html:12 > > + <script src="beacon-common.js?pipe=sub"></script> > > Style only but it would be nicer to rename beacon-common.js as > beacon-common.sub.js and remove the ?pipe=sub > > Looking at beacon-common.js, the polling mechanism seems fine. > I would tend though to stop polling and raise an error after a long timeout > like 5 seconds but I am not sure how WPT would like that change. Would you mind making those comments upstream at https://github.com/w3c/web-platform-tests/pull/6655 ?
Comment on attachment 317716 [details] Patch Attachment 317716 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4284999 New failing tests: imported/w3c/web-platform-tests/beacon/beacon-navigate.html
Created attachment 317722 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 317716 [details] Patch Attachment 317716 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4285112 New failing tests: imported/w3c/web-platform-tests/beacon/beacon-navigate.html
Created attachment 317723 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 317737 [details] Patch
Comment on attachment 317737 [details] Patch Attachment 317737 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4286207 New failing tests: imported/w3c/web-platform-tests/beacon/beacon-navigate.html
Created attachment 317752 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 317737 [details] Patch Attachment 317737 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4286279 New failing tests: imported/w3c/web-platform-tests/beacon/beacon-navigate.html
Created attachment 317753 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 317737 [details] Patch Attachment 317737 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4286234 New failing tests: imported/w3c/web-platform-tests/beacon/beacon-navigate.html
Created attachment 317754 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6