Bug 175382 – Parse font-display

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Myles C. Maxfield]

Parse font-display

[Myles C. Maxfield]

Created attachment 317708 [details]
WIP

[Radar WebKit Bug Importer]

<rdar://problem/33813229>

[Myles C. Maxfield]

Created attachment 317771 [details]
WIP

[Myles C. Maxfield]

Created attachment 317787 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 317787 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317787&action=review

> Source/WebCore/css/CSSFontFace.cpp:409
> +    iterateClients(m_clients, [&](Client& client) {
> +        client.fontPropertyChanged(*this);
> +    });

Should you detect whether it's being set to the existing values, and therefore hasn't changed?

> Source/WebCore/css/CSSValueKeywords.in:1354
> +swap
> +fallback
> +optional

We usually list them all, and comment out the replicated ones.

[Myles C. Maxfield]

Created attachment 318063 [details]
Patch for committing

[WebKit Commit Bot]

Comment on attachment 318063 [details]
Patch for committing

Clearing flags on attachment: 318063

Committed r220725: <http://trac.webkit.org/changeset/220725>

[Darin Adler]

Comment on attachment 318063 [details]
Patch for committing

View in context: https://bugs.webkit.org/attachment.cgi?id=318063&action=review

> Source/WebCore/css/CSSFontFace.cpp:273
> +    if (ranges.size() == m_ranges.size()) {
> +        bool same = true;
> +        for (size_t i = 0; i < ranges.size(); ++i) {
> +            if (ranges[i] != m_ranges[i]) {
> +                same = false;
> +                break;
> +            }
> +        }
> +        if (same)
> +            return true;
>      }

This should just be:

    if (ranges == m_ranges)
        return true;

Vector already has an operator== that does this.

[Myles C. Maxfield]

Committed r220986: <http://trac.webkit.org/changeset/220986>