Bug 175377 – [WPE] Use the device scale factor value in WebPageCreationParameters

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

[WPE] Use the device scale factor value in WebPageCreationParameters

[Zan Dobersek]

Created attachment 317695 [details]
Patch

[Michael Catanzaro]

I know it's only one line, but you need an owner for this.

[Zan Dobersek]

(In reply to Michael Catanzaro from comment #2)
> I know it's only one line, but you need an owner for this.

The file is specific to the GTK+ and WPE ports, despite its location.

r221344, being most recent change here, didn't require an owner.
https://trac.webkit.org/changeset/221344/webkit

[Michael Catanzaro]

Comment on attachment 317695 [details]
Patch

I didn't realize it was our file. OK then.

[Zan Dobersek]

Comment on attachment 317695 [details]
Patch

Clearing flags on attachment: 317695

Committed r221571: <http://trac.webkit.org/changeset/221571>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34694437>

[Carlos Garcia Campos]

Comment on attachment 317695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317695&action=review

> Source/WebKit/ChangeLog:15
> +        which enters accelerated mode unconditionally and as such doesn't
> +        wait for the backing store update that would provide that value
> +        otherwise.

This value is not provided by backing store update, it's set from the parameters in the WebPage constructor, just a few lines below the drawing area creation. Are you sure we need to set this twice? If we need to set it earlier we can just move the lines right after the drawing area creation.