Bug 175377 - [WPE] Use the device scale factor value in WebPageCreationParameters
Summary: [WPE] Use the device scale factor value in WebPageCreationParameters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-09 05:14 PDT by Zan Dobersek
Modified: 2017-10-16 01:09 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.73 KB, patch)
2017-08-09 05:24 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-08-09 05:14:06 PDT 
[WPE] Use the device scale factor value in WebPageCreationParameters
Comment 1 Zan Dobersek 2017-08-09 05:24:09 PDT 
Created attachment 317695 [details]
Patch
Comment 2 Michael Catanzaro 2017-09-01 17:54:20 PDT 
I know it's only one line, but you need an owner for this.
Comment 3 Zan Dobersek 2017-09-02 00:31:56 PDT 
(In reply to Michael Catanzaro from comment #2)
> I know it's only one line, but you need an owner for this.

The file is specific to the GTK+ and WPE ports, despite its location.

r221344, being most recent change here, didn't require an owner.
https://trac.webkit.org/changeset/221344/webkit
Comment 4 Michael Catanzaro 2017-09-02 10:19:48 PDT 
Comment on attachment 317695 [details]
Patch

I didn't realize it was our file. OK then.
Comment 5 Zan Dobersek 2017-09-03 23:03:03 PDT 
Comment on attachment 317695 [details]
Patch

Clearing flags on attachment: 317695

Committed r221571: <http://trac.webkit.org/changeset/221571>
Comment 6 Zan Dobersek 2017-09-03 23:03:07 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-09-27 12:59:32 PDT 
<rdar://problem/34694437>
Comment 8 Carlos Garcia Campos 2017-10-16 01:09:31 PDT 
Comment on attachment 317695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317695&action=review

> Source/WebKit/ChangeLog:15
> +        which enters accelerated mode unconditionally and as such doesn't
> +        wait for the backing store update that would provide that value
> +        otherwise.

This value is not provided by backing store update, it's set from the parameters in the WebPage constructor, just a few lines below the drawing area creation. Are you sure we need to set this twice? If we need to set it earlier we can just move the lines right after the drawing area creation.