Bug 175351 - REGRESSION (r220393): LayoutTest editing/selection/move-by-word-visually-multi-space.html is timing out
Summary: REGRESSION (r220393): LayoutTest editing/selection/move-by-word-visually-mult...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-08 15:56 PDT by Ryan Haddad
Modified: 2017-11-15 13:11 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Ryan Haddad 2017-08-08 16:00:09 PDT
This started with https://trac.webkit.org/changeset/220393/webkit

Looking at the flakiness dashboard, the test went from passing to a consistent timeout on iOS 10 Simulator Debug WK2,  El Capitan Debug WK2, and Sierra Debug WK2. The test is already marked as a flaky timeout on Sierra Debug WK2.
Comment 2 Wenson Hsieh 2017-08-08 19:17:31 PDT
(In reply to Ryan Haddad from comment #1)
> This started with https://trac.webkit.org/changeset/220393/webkit
> 
> Looking at the flakiness dashboard, the test went from passing to a
> consistent timeout on iOS 10 Simulator Debug WK2,  El Capitan Debug WK2, and
> Sierra Debug WK2. The test is already marked as a flaky timeout on Sierra
> Debug WK2.

This test passes consistently for me on High Sierra, with a debug build. Will try using Sierra...
Comment 3 Alexey Proskuryakov 2017-08-08 22:07:06 PDT
I suggest rolling back until this can be fixed.
Comment 4 Wenson Hsieh 2017-08-08 22:31:25 PDT
(In reply to Wenson Hsieh from comment #2)
> (In reply to Ryan Haddad from comment #1)
> > This started with https://trac.webkit.org/changeset/220393/webkit
> > 
> > Looking at the flakiness dashboard, the test went from passing to a
> > consistent timeout on iOS 10 Simulator Debug WK2,  El Capitan Debug WK2, and
> > Sierra Debug WK2. The test is already marked as a flaky timeout on Sierra
> > Debug WK2.
> 
> This test passes consistently for me on High Sierra, with a debug build.
> Will try using Sierra...

...actually, this might be timing out now because the test is just taking longer than it did before. Time profiling instrumentation shows that WebPage::editorState is taking longer than it did previously, due to EditingStyle::styleAtSelectionStart being more expensive in this test case than Editor::styleForSelectionStart.
Comment 5 Wenson Hsieh 2017-08-08 22:32:14 PDT
(In reply to Alexey Proskuryakov from comment #3)
> I suggest rolling back until this can be fixed.

I think that's a good call. I'll roll it out.
Comment 6 Wenson Hsieh 2017-08-08 22:41:51 PDT
(In reply to Wenson Hsieh from comment #5)
> (In reply to Alexey Proskuryakov from comment #3)
> > I suggest rolling back until this can be fixed.
> 
> I think that's a good call. I'll roll it out.

Rolled out in <http://trac.webkit.org/changeset/220443>.
Comment 7 Radar WebKit Bug Importer 2017-11-15 13:11:43 PST
<rdar://problem/35568969>