Bug 175351 – REGRESSION (r220393): LayoutTest editing/selection/move-by-word-visually-multi-space.html is timing out

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: HTML Editing

[Ryan Haddad]

LayoutTest editing/selection/move-by-word-visually-multi-space.html is timing out

https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/builds/3187

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2Fselection%2Fmove-by-word-visually-multi-space.html

[Ryan Haddad]

This started with https://trac.webkit.org/changeset/220393/webkit

Looking at the flakiness dashboard, the test went from passing to a consistent timeout on iOS 10 Simulator Debug WK2,  El Capitan Debug WK2, and Sierra Debug WK2. The test is already marked as a flaky timeout on Sierra Debug WK2.

[Wenson Hsieh]

(In reply to Ryan Haddad from comment #1)
> This started with https://trac.webkit.org/changeset/220393/webkit
> 
> Looking at the flakiness dashboard, the test went from passing to a
> consistent timeout on iOS 10 Simulator Debug WK2,  El Capitan Debug WK2, and
> Sierra Debug WK2. The test is already marked as a flaky timeout on Sierra
> Debug WK2.

This test passes consistently for me on High Sierra, with a debug build. Will try using Sierra...

[Alexey Proskuryakov]

I suggest rolling back until this can be fixed.

[Wenson Hsieh]

(In reply to Wenson Hsieh from comment #2)
> (In reply to Ryan Haddad from comment #1)
> > This started with https://trac.webkit.org/changeset/220393/webkit
> > 
> > Looking at the flakiness dashboard, the test went from passing to a
> > consistent timeout on iOS 10 Simulator Debug WK2,  El Capitan Debug WK2, and
> > Sierra Debug WK2. The test is already marked as a flaky timeout on Sierra
> > Debug WK2.
> 
> This test passes consistently for me on High Sierra, with a debug build.
> Will try using Sierra...

...actually, this might be timing out now because the test is just taking longer than it did before. Time profiling instrumentation shows that WebPage::editorState is taking longer than it did previously, due to EditingStyle::styleAtSelectionStart being more expensive in this test case than Editor::styleForSelectionStart.

[Wenson Hsieh]

(In reply to Alexey Proskuryakov from comment #3)
> I suggest rolling back until this can be fixed.

I think that's a good call. I'll roll it out.

[Wenson Hsieh]

(In reply to Wenson Hsieh from comment #5)
> (In reply to Alexey Proskuryakov from comment #3)
> > I suggest rolling back until this can be fixed.
> 
> I think that's a good call. I'll roll it out.

Rolled out in <http://trac.webkit.org/changeset/220443>.

[Radar WebKit Bug Importer]

<rdar://problem/35568969>