Bug 175339 - Change the animated image tests to use the 'webkitImageFrameReady' event
Summary: Change the animated image tests to use the 'webkitImageFrameReady' event
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-08 13:05 PDT by Said Abou-Hallawa
Modified: 2017-10-13 16:55 PDT (History)
4 users (show)

See Also:


Attachments
Patch (41.45 KB, patch)
2017-08-08 13:12 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1011.15 KB, application/zip)
2017-08-08 14:26 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.77 MB, application/zip)
2017-08-08 14:46 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.07 MB, application/zip)
2017-08-08 14:57 PDT, Build Bot
no flags Details
Patch (61.89 KB, patch)
2017-10-12 16:55 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch (62.30 KB, patch)
2017-10-13 08:50 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch (68.62 KB, patch)
2017-10-13 11:48 PDT, Said Abou-Hallawa
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-elcapitan (1.10 MB, application/zip)
2017-10-13 14:11 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.21 MB, application/zip)
2017-10-13 14:21 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews115 for mac-elcapitan (2.02 MB, application/zip)
2017-10-13 16:55 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2017-08-08 13:05:58 PDT
The 'webkitImageFrameReady' event is used in some tests but not in all the tests. The tests which do not use it, use the Internals.setImageFrameDecodingDuration() API. This API tries to synchronize the image decoding with the drawing actions. Using the 'webkitImageFrameReady' event can synchronize the decoding better and more reliable. So the requirements are:

1. Use the 'webkitImageFrameReady' event to detect exactly when an image frame is ready for drawing.
2. Remove Internals.setImageFrameDecodingDuration() API. Instead add Internals.setAnimatedImageAsyncDecodingEnabledForTesting() which is similar to Internals.setLargeImageAsyncDecodingEnabledForTesting(). Use the new API to force asynchronous decoding for animated images.
Comment 1 Said Abou-Hallawa 2017-08-08 13:12:21 PDT
Created attachment 317602 [details]
Patch
Comment 2 Build Bot 2017-08-08 14:26:20 PDT
Comment on attachment 317602 [details]
Patch

Attachment 317602 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4279708

New failing tests:
fast/images/clear-animation-decoder.html
fast/images/slower-decoding-than-animation-image.html
fast/images/stopped-animation-deleted-image.html
fast/images/animated-image-draw-while-decode.html
Comment 3 Build Bot 2017-08-08 14:26:21 PDT
Created attachment 317615 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-08-08 14:46:09 PDT
Comment on attachment 317602 [details]
Patch

Attachment 317602 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4279714

New failing tests:
fast/images/clear-animation-decoder.html
fast/images/slower-decoding-than-animation-image.html
fast/images/stopped-animation-deleted-image.html
fast/images/animated-image-draw-while-decode.html
Comment 5 Build Bot 2017-08-08 14:46:11 PDT
Created attachment 317620 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-08-08 14:57:06 PDT
Comment on attachment 317602 [details]
Patch

Attachment 317602 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4279741

New failing tests:
fast/images/reset-image-animation.html
Comment 7 Build Bot 2017-08-08 14:57:07 PDT
Created attachment 317622 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 8 Radar WebKit Bug Importer 2017-08-28 13:44:57 PDT
<rdar://problem/34117622>
Comment 9 Said Abou-Hallawa 2017-10-12 16:55:42 PDT
Created attachment 323601 [details]
Patch
Comment 10 Said Abou-Hallawa 2017-10-13 08:50:33 PDT
Created attachment 323674 [details]
Patch
Comment 11 Said Abou-Hallawa 2017-10-13 11:48:57 PDT
Created attachment 323717 [details]
Patch
Comment 12 Build Bot 2017-10-13 14:11:31 PDT
Comment on attachment 323717 [details]
Patch

Attachment 323717 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4849998

New failing tests:
fast/images/clear-animation-decoder.html
fast/images/decode-animated-image.html
fast/images/stopped-animation-deleted-image.html
fast/images/decode-render-animated-image.html
fast/images/animated-image-draw-while-decode.html
fast/images/animated-image-different-dest-size.html
fast/images/slower-decoding-than-animation-image.html
Comment 13 Build Bot 2017-10-13 14:11:33 PDT
Created attachment 323744 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 14 Build Bot 2017-10-13 14:21:28 PDT
Comment on attachment 323717 [details]
Patch

Attachment 323717 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4850057

New failing tests:
fast/images/clear-animation-decoder.html
fast/images/decode-animated-image.html
fast/images/stopped-animation-deleted-image.html
fast/images/decode-render-animated-image.html
fast/images/animated-image-draw-while-decode.html
fast/images/animated-image-different-dest-size.html
fast/images/slower-decoding-than-animation-image.html
Comment 15 Build Bot 2017-10-13 14:21:29 PDT
Created attachment 323747 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 16 Build Bot 2017-10-13 16:55:41 PDT
Comment on attachment 323717 [details]
Patch

Attachment 323717 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4851596

New failing tests:
fast/images/clear-animation-decoder.html
fast/images/decode-animated-image.html
fast/images/stopped-animation-deleted-image.html
fast/images/decode-render-animated-image.html
fast/images/animated-image-draw-while-decode.html
fast/images/animated-image-different-dest-size.html
fast/images/slower-decoding-than-animation-image.html
Comment 17 Build Bot 2017-10-13 16:55:43 PDT
Created attachment 323772 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6