Bug 175339 – Change the animated image tests to use the 'webkitImageFrameReady' event

• Status: NEW
• Component: Images

[Said Abou-Hallawa]

The 'webkitImageFrameReady' event is used in some tests but not in all the tests. The tests which do not use it, use the Internals.setImageFrameDecodingDuration() API. This API tries to synchronize the image decoding with the drawing actions. Using the 'webkitImageFrameReady' event can synchronize the decoding better and more reliable. So the requirements are:

1. Use the 'webkitImageFrameReady' event to detect exactly when an image frame is ready for drawing.
2. Remove Internals.setImageFrameDecodingDuration() API. Instead add Internals.setAnimatedImageAsyncDecodingEnabledForTesting() which is similar to Internals.setLargeImageAsyncDecodingEnabledForTesting(). Use the new API to force asynchronous decoding for animated images.

[Said Abou-Hallawa]

Created attachment 317602 [details]
Patch

[Build Bot]

Comment on attachment 317602 [details]
Patch

Attachment 317602 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4279708

New failing tests:
fast/images/clear-animation-decoder.html
fast/images/slower-decoding-than-animation-image.html
fast/images/stopped-animation-deleted-image.html
fast/images/animated-image-draw-while-decode.html

[Build Bot]

Created attachment 317615 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 317602 [details]
Patch

Attachment 317602 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4279714

New failing tests:
fast/images/clear-animation-decoder.html
fast/images/slower-decoding-than-animation-image.html
fast/images/stopped-animation-deleted-image.html
fast/images/animated-image-draw-while-decode.html

[Build Bot]

Created attachment 317620 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 317602 [details]
Patch

Attachment 317602 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4279741

New failing tests:
fast/images/reset-image-animation.html

[Build Bot]

Created attachment 317622 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Radar WebKit Bug Importer]

<rdar://problem/34117622>

[Said Abou-Hallawa]

Created attachment 323601 [details]
Patch

[Said Abou-Hallawa]

Created attachment 323674 [details]
Patch

[Said Abou-Hallawa]

Created attachment 323717 [details]
Patch

[Build Bot]

Comment on attachment 323717 [details]
Patch

Attachment 323717 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4849998

New failing tests:
fast/images/clear-animation-decoder.html
fast/images/decode-animated-image.html
fast/images/stopped-animation-deleted-image.html
fast/images/decode-render-animated-image.html
fast/images/animated-image-draw-while-decode.html
fast/images/animated-image-different-dest-size.html
fast/images/slower-decoding-than-animation-image.html

[Build Bot]

Created attachment 323744 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 323717 [details]
Patch

Attachment 323717 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4850057

New failing tests:
fast/images/clear-animation-decoder.html
fast/images/decode-animated-image.html
fast/images/stopped-animation-deleted-image.html
fast/images/decode-render-animated-image.html
fast/images/animated-image-draw-while-decode.html
fast/images/animated-image-different-dest-size.html
fast/images/slower-decoding-than-animation-image.html

[Build Bot]

Created attachment 323747 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 323717 [details]
Patch

Attachment 323717 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4851596

New failing tests:
fast/images/clear-animation-decoder.html
fast/images/decode-animated-image.html
fast/images/stopped-animation-deleted-image.html
fast/images/decode-render-animated-image.html
fast/images/animated-image-draw-while-decode.html
fast/images/animated-image-different-dest-size.html
fast/images/slower-decoding-than-animation-image.html

[Build Bot]

Created attachment 323772 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6