LayoutTest imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-stringifier.html is a flaky failure https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r220403%20(3594)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Ftext-level-semantics%2Fthe-a-element%2Fa-stringifier.html --- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-stringifier-expected.txt +++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-stringifier-actual.txt @@ -1,3 +1,4 @@ +Download completed. PASS HTMLAnchorElement stringifier PASS HTMLAnchorElement stringifier 1
This is likely caused by a previous test. a-stringifier.html is unlikely to be the culprit here :(
It is likely that a download layout test is not properly waiting for the download to finish to call finishJSTest().
The culprit is likely: imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html It clicks a download link and calls done() right away.
It looks like download tests are currently expected to use: if (window.testRunner) testRunner.waitUntilDownloadFinished();
*** Bug 168235 has been marked as a duplicate of this bug. ***
Created attachment 317967 [details] Patch
Comment on attachment 317967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317967&action=review > Tools/ChangeLog:8 > + - Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished() We don't have the support for this feature in DRT?
(In reply to Ryosuke Niwa from comment #7) > Comment on attachment 317967 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=317967&action=review > > > Tools/ChangeLog:8 > > + - Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished() > > We don't have the support for this feature in DRT? No it was apparently only added to WK2.
Comment on attachment 317967 [details] Patch Clearing flags on attachment: 317967 Committed r220626: <http://trac.webkit.org/changeset/220626>
All reviewed patches have been landed. Closing bug.
<rdar://problem/33865119>
Committed r220703: <http://trac.webkit.org/changeset/220703>
Small follow-up in https://trac.webkit.org/r220703.