Bug 175334 - REGRESSION: 2 test262/test/language/statements/async-function failures
Summary: REGRESSION: 2 test262/test/language/statements/async-function failures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: GSkachkov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-08 11:34 PDT by Ryan Haddad
Modified: 2017-08-09 02:19 PDT (History)
10 users (show)

See Also:


Attachments
Patch (3.74 KB, patch)
2017-08-09 00:36 PDT, GSkachkov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-08-08 11:34:45 PDT
test262.yaml/test262/test/language/statements/async-function/early-errors-no-async-generator.js.default: ERROR: Unexpected exit code: 3
test262.yaml/test262/test/language/statements/async-function/early-errors-no-async-generator.js.default-strict: ERROR: Unexpected exit code: 3
FAIL: test262.yaml/test262/test/language/statements/async-function/early-errors-no-async-generator.js.default-strict
FAIL: test262.yaml/test262/test/language/statements/async-function/early-errors-no-async-generator.js.default

https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20Test262%20%28Tests%29/builds/3197
Comment 1 Ryan Haddad 2017-08-08 11:49:42 PDT
These failures started after https://trac.webkit.org/r220323 landed.
Comment 2 GSkachkov 2017-08-08 12:10:31 PDT
Ohh, I did not expect that async function check that there is no async generator
I'll provide patch
Comment 3 Yusuke Suzuki 2017-08-08 12:12:38 PDT
(In reply to GSkachkov from comment #2)
> Ohh, I did not expect that async function check that there is no async
> generator
> I'll provide patch

I think it's safe to make useAsyncIterator false until you finish async iterator work.
In that case, you can specify @skip for async iterator JSTests for now.

After your work is finished, you can set/remove useAsyncIterator flag. And you can specify :failDueToOutdatedOrBadTest in test262.yaml.
Comment 4 GSkachkov 2017-08-09 00:36:01 PDT
Created attachment 317688 [details]
Patch

Patch
Comment 5 Yusuke Suzuki 2017-08-09 00:45:19 PDT
Comment on attachment 317688 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2017-08-09 02:17:48 PDT
Comment on attachment 317688 [details]
Patch

Clearing flags on attachment: 317688

Committed r220449: <http://trac.webkit.org/changeset/220449>
Comment 7 WebKit Commit Bot 2017-08-09 02:17:49 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-08-09 02:19:11 PDT
<rdar://problem/33795638>