Bug 175312 - Reinstate active flag for iterators
Summary: Reinstate active flag for iterators
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-08 00:11 PDT by Anne van Kesteren
Modified: 2017-08-09 06:05 PDT (History)
11 users (show)

See Also:


Attachments
Patch (20.35 KB, patch)
2017-08-08 14:36 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (21.29 KB, patch)
2017-08-08 15:30 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (21.76 KB, patch)
2017-08-08 15:34 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2017-08-08 00:11:22 PDT
Change to standard: https://github.com/whatwg/dom/pull/359

Tests: https://github.com/w3c/web-platform-tests/pull/5651
Comment 1 Chris Dumez 2017-08-08 12:23:44 PDT
http://w3c-test.org/dom/traversal/NodeIterator.html
http://w3c-test.org/dom/traversal/TreeWalker.html

"Recursive Filters need to throw" check is failing.
Comment 2 Chris Dumez 2017-08-08 14:36:21 PDT
Created attachment 317616 [details]
Patch
Comment 3 Chris Dumez 2017-08-08 15:30:01 PDT
Created attachment 317630 [details]
Patch
Comment 4 Chris Dumez 2017-08-08 15:34:00 PDT
Created attachment 317632 [details]
Patch
Comment 5 WebKit Commit Bot 2017-08-09 06:04:43 PDT
Comment on attachment 317632 [details]
Patch

Clearing flags on attachment: 317632

Committed r220453: <http://trac.webkit.org/changeset/220453>
Comment 6 WebKit Commit Bot 2017-08-09 06:04:44 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-08-09 06:05:47 PDT
<rdar://problem/33798308>