NEW 175309
Disable acceleration for small canvases
https://bugs.webkit.org/show_bug.cgi?id=175309
Summary Disable acceleration for small canvases
Simon Fraser (smfr)
Reported 2017-08-07 19:37:18 PDT
Disable acceleration for small canvases
Attachments
Patch (1.62 KB, patch)
2017-08-07 19:38 PDT, Simon Fraser (smfr)
no flags
Patch (1.85 KB, patch)
2017-08-07 20:28 PDT, Simon Fraser (smfr)
no flags
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.75 MB, application/zip)
2017-08-07 21:43 PDT, Build Bot
no flags
Simon Fraser (smfr)
Comment 1 2017-08-07 19:38:33 PDT
Sam Weinig
Comment 2 2017-08-07 20:16:04 PDT
Comment on attachment 317532 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317532&action=review Can > Source/WebCore/html/HTMLCanvasElement.cpp:728 > + if (area < settings.minimumAccelerated2dCanvasSize()) > + return false; > + > return settings.canvasUsesAcceleratedDrawing(); > #elif ENABLE(ACCELERATED_2D_CANVAS) > if (m_context && !m_context->is2d()) Can we move this up, out of the #if and remove the copy of it below?
Simon Fraser (smfr)
Comment 3 2017-08-07 20:28:59 PDT
Simon Fraser (smfr)
Comment 4 2017-08-07 20:29:14 PDT
Your wish is my command.
Build Bot
Comment 5 2017-08-07 21:43:06 PDT
Comment on attachment 317536 [details] Patch Attachment 317536 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4274609 New failing tests: compositing/canvas/accelerated-canvas-compositing.html compositing/canvas/accelerated-canvas-compositing-size-limit.html fast/canvas/canvas-ellipse-zero-lineto.html fast/repaint/canvas-putImageData.html inspector/canvas/memory.html fast/canvas/canvas-scale-shadowBlur.html fast/canvas/canvas-strokePath-gradient-shadow.html fast/canvas/canvas-strokeRect-gradient-shadow.html fast/canvas/canvas-blending-global-alpha.html compositing/layer-creation/spanOverlapsCanvas.html fast/canvas/canvas-render-layer.html webrtc/captureCanvas-webrtc.html css3/blending/blend-mode-clip-accelerated-blending-canvas.html
Build Bot
Comment 6 2017-08-07 21:43:08 PDT
Created attachment 317540 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Sam Weinig
Comment 7 2017-08-07 22:11:23 PDT
Comment on attachment 317536 [details] Patch I think you moved the wrong one :(. You meant to move the settings.minimumAccelerated2dCanvasSize(). Go to bed!
Tim Horton
Comment 8 2017-08-07 22:16:22 PDT
Comment on attachment 317536 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317536&action=review > Source/WebCore/ChangeLog:8 > + For canvases with area less than 257*256, use the software rendering code path. This improves Wonder if we should downgrade you to software the first time you use get/putImageData instead. Best of both worlds?
Simon Fraser (smfr)
Comment 9 2017-08-07 22:46:40 PDT
Comment on attachment 317536 [details] Patch You are right.
Radar WebKit Bug Importer
Comment 10 2017-08-15 18:55:07 PDT
Note You need to log in before you can comment on or make changes to this bug.