Bug 175309 – Disable acceleration for small canvases

• Status: NEW
• Component: Canvas

[Simon Fraser (smfr)]

Disable acceleration for small canvases

[Simon Fraser (smfr)]

Created attachment 317532 [details]
Patch

[Sam Weinig]

Comment on attachment 317532 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317532&action=review

Can

> Source/WebCore/html/HTMLCanvasElement.cpp:728
> +    if (area < settings.minimumAccelerated2dCanvasSize())
> +        return false;
> +
>      return settings.canvasUsesAcceleratedDrawing();
>  #elif ENABLE(ACCELERATED_2D_CANVAS)
>      if (m_context && !m_context->is2d())

Can we move this up, out of the #if and remove the copy of it below?

[Simon Fraser (smfr)]

Created attachment 317536 [details]
Patch

[Simon Fraser (smfr)]

Your wish is my command.

[Build Bot]

Comment on attachment 317536 [details]
Patch

Attachment 317536 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4274609

New failing tests:
compositing/canvas/accelerated-canvas-compositing.html
compositing/canvas/accelerated-canvas-compositing-size-limit.html
fast/canvas/canvas-ellipse-zero-lineto.html
fast/repaint/canvas-putImageData.html
inspector/canvas/memory.html
fast/canvas/canvas-scale-shadowBlur.html
fast/canvas/canvas-strokePath-gradient-shadow.html
fast/canvas/canvas-strokeRect-gradient-shadow.html
fast/canvas/canvas-blending-global-alpha.html
compositing/layer-creation/spanOverlapsCanvas.html
fast/canvas/canvas-render-layer.html
webrtc/captureCanvas-webrtc.html
css3/blending/blend-mode-clip-accelerated-blending-canvas.html

[Build Bot]

Created attachment 317540 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Sam Weinig]

Comment on attachment 317536 [details]
Patch

I think you moved the wrong one :(. You meant to move the settings.minimumAccelerated2dCanvasSize(). Go to bed!

[Tim Horton]

Comment on attachment 317536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317536&action=review

> Source/WebCore/ChangeLog:8
> +        For canvases with area less than 257*256, use the software rendering code path. This improves

Wonder if we should downgrade you to software the first time you use get/putImageData instead. Best of both worlds?

[Simon Fraser (smfr)]

Comment on attachment 317536 [details]
Patch

You are right.

[Radar WebKit Bug Importer]

<rdar://problem/33910457>